Re: [kvm-ppc-devel] [PATCH 2/3] Split kvmctl for architectures

[Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

Ok, so some useful feedback :-). I'm going to rework these patches
completely. Have them share a LOT more then these now. Which is
basically a total spilt.

On Thu, 2007-10-18 at 15:40 -0500, Hollis Blanchard wrote:
> On Thu, 2007-10-18 at 15:37 -0500, Jerone Young wrote:
> > On Thu, 2007-10-18 at 15:28 -0500, Anthony Liguori wrote:
> > > 
> > > A quick glance suggests that there's a lot of code duplication between 
> > > things like main-x86.c and main-ppc.c.  Perhaps the common code could be 
> > > unified?
> > 
> > I do have a main.c with ifdefs. But the feeling here is that as things
> > are added this gets hair really quick. Right now it's ok with only 2
> > main architectures. But if others come in, this file could turn into an
> > ifdef mess.
> > 
> > I really have no strong feelings on it. I can combine them.
> 
> Contrary to popular belief, we can share code between multiple
> architectures without using ifdefs...
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/