Re: [PATCH 2/3] Split kvmctl for architectures

[Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>]

Jerone Young wrote:
> This patch splits kvmctl architecture specific declarations &
> implementations into their own files & headers. Common interfaces are
> kept in kvmctl.h, as well as the arch specific headers are included from
> within kvmctl.h. This may or may not want to be changed.
>
>  Also includes the having different main.c files for different
> architectures (otherwise it's a lot of ifdefs). 
>
> Signed-off-by: Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>   

This patch is pretty hard to reasonably review since diff is so large.

A quick glance suggests that there's a lot of code duplication between 
things like main-x86.c and main-ppc.c.  Perhaps the common code could be 
unified?

Regards,

Anthony Liguori


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/