From: Hollis Blanchard <hollisb@us.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Avi Kivity <avi@qumranet.com>,
kvm-devel <kvm-devel@lists.sourceforge.net>,
Laurent Vivier <Laurent.Vivier@bull.net>,
linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] Use virtual cpu accounting if available for guest times.
Date: Fri, 19 Oct 2007 12:18:56 -0500 [thread overview]
Message-ID: <1192814336.10451.20.camel@basalt> (raw)
In-Reply-To: <1192813056.10451.6.camel@basalt>
On Fri, 2007-10-19 at 11:57 -0500, Hollis Blanchard wrote:
> > @@ -669,11 +670,13 @@ __init void kvm_arch_init(void);
> >
> > static inline void kvm_guest_enter(void)
> > {
> > + account_system_vtime(current);
> > current->flags |= PF_VCPU;
> > }
> >
> > static inline void kvm_guest_exit(void)
> > {
> > + account_system_vtime(current);
> > current->flags &= ~PF_VCPU;
> > }
>
> I don't understand. Should kvm_guest_exit() be calling
> account_user_vtime() (instead of account_system_vtime())?
Never mind; the tree I was looking at didn't have the
account_guest_time() stuff in account_system_time().
--
Hollis Blanchard
IBM Linux Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Christian Borntraeger
<borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: Use virtual cpu accounting if available for guest times.
Date: Fri, 19 Oct 2007 12:18:56 -0500 [thread overview]
Message-ID: <1192814336.10451.20.camel@basalt> (raw)
In-Reply-To: <1192813056.10451.6.camel@basalt>
On Fri, 2007-10-19 at 11:57 -0500, Hollis Blanchard wrote:
> > @@ -669,11 +670,13 @@ __init void kvm_arch_init(void);
> >
> > static inline void kvm_guest_enter(void)
> > {
> > + account_system_vtime(current);
> > current->flags |= PF_VCPU;
> > }
> >
> > static inline void kvm_guest_exit(void)
> > {
> > + account_system_vtime(current);
> > current->flags &= ~PF_VCPU;
> > }
>
> I don't understand. Should kvm_guest_exit() be calling
> account_user_vtime() (instead of account_system_vtime())?
Never mind; the tree I was looking at didn't have the
account_guest_time() stuff in account_system_time().
--
Hollis Blanchard
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-19 17:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 14:13 [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting Laurent Vivier
2007-10-15 9:38 ` Ingo Molnar
2007-10-15 9:47 ` Avi Kivity
2007-10-15 9:50 ` Ingo Molnar
2007-10-15 9:51 ` Ingo Molnar
2007-10-15 10:02 ` Avi Kivity
2007-10-15 10:53 ` Laurent Vivier
2007-10-15 11:15 ` Avi Kivity
2007-10-15 11:33 ` Christian Borntraeger
2007-10-15 11:38 ` Laurent Vivier
2007-10-15 14:39 ` Christian Borntraeger
2007-10-15 14:45 ` Laurent Vivier
2007-10-15 11:37 ` Laurent Vivier
2007-10-15 12:07 ` Avi Kivity
2007-10-15 12:29 ` Laurent Vivier
2007-10-15 16:46 ` Avi Kivity
2007-10-15 19:45 ` Laurent Vivier
2007-10-17 13:08 ` [PATCH] clear PF_VCPU in kvm_guest_exit() Laurent Vivier
2007-10-17 13:18 ` Christian Borntraeger
2007-10-17 14:16 ` Avi Kivity
2007-10-17 15:09 ` Laurent Vivier
2007-10-18 12:39 ` Use virtual cpu accounting if available for guest times Christian Borntraeger
2007-10-18 12:39 ` Christian Borntraeger
2007-10-18 12:41 ` Avi Kivity
2007-10-18 12:41 ` Avi Kivity
2007-10-19 16:57 ` [kvm-devel] " Hollis Blanchard
2007-10-19 17:18 ` Hollis Blanchard [this message]
2007-10-19 17:18 ` Hollis Blanchard
2007-10-18 13:19 ` [PATCH] move kvm_guest_exit() after local_irq_enable() Laurent Vivier
2007-10-18 13:32 ` [kvm-devel] " Avi Kivity
2007-10-18 13:32 ` Avi Kivity
2007-10-18 13:49 ` [kvm-devel] " Laurent Vivier
2007-10-22 8:26 ` Ingo Molnar
2007-10-22 8:26 ` Ingo Molnar
2007-10-22 8:51 ` Avi Kivity
2007-10-22 8:51 ` Avi Kivity
2007-10-22 8:57 ` Ingo Molnar
2007-10-22 8:57 ` Ingo Molnar
2007-10-22 9:10 ` [kvm-devel] " Avi Kivity
2007-10-22 9:10 ` Avi Kivity
2007-10-15 11:19 ` [RESEND 2][PATCH 4/4] Modify KVM to update guest time accounting Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192814336.10451.20.camel@basalt \
--to=hollisb@us.ibm.com \
--cc=Laurent.Vivier@bull.net \
--cc=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.