All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Michael Ellerman <ellerman@au1.ibm.com>,
	netdev@vger.kernel.org, mcarlson@broadcom.com,
	linuxppc-dev@ozlabs.org, mchan@broadcom.com,
	linux-pci@atrey.karlin.mff.cuni.cz,
	David Miller <davem@davemloft.net>
Subject: Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function
Date: Sat, 20 Oct 2007 11:29:40 +1000	[thread overview]
Message-ID: <1192843780.17235.17.camel@pasglop> (raw)
In-Reply-To: <20071020004610.GR29903@austin.ibm.com>


> I'm cc'ing the powerpc mailing list to point this out: 
> it looks like only cell/axon_msi.c and mpic_u3msi.c 
> bother do do anything.  I guess that there aren't any old 
> macintosh laptops that have msi on them? Because without
> this, suspend and resume breaks.

The only macs that can do any form of MSIs are the G5s using
mpic_u3msi.c

> Paul,
> On the off chance your reading this, I'll send a pseries
> patch on Monday, with luck (and some other patches too).
> I'm not touching any of the other plaforms, you and benh 
> would know those better.

Or rather Michael as he wrote the ppc MSI support. I'll check with him

Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: David Miller <davem@davemloft.net>,
	linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
	linux-pci@atrey.karlin.mff.cuni.cz, mcarlson@broadcom.com,
	mchan@broadcom.com, Michael Ellerman <ellerman@au1.ibm.com>
Subject: Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function
Date: Sat, 20 Oct 2007 11:29:40 +1000	[thread overview]
Message-ID: <1192843780.17235.17.camel@pasglop> (raw)
In-Reply-To: <20071020004610.GR29903@austin.ibm.com>


> I'm cc'ing the powerpc mailing list to point this out: 
> it looks like only cell/axon_msi.c and mpic_u3msi.c 
> bother do do anything.  I guess that there aren't any old 
> macintosh laptops that have msi on them? Because without
> this, suspend and resume breaks.

The only macs that can do any form of MSIs are the G5s using
mpic_u3msi.c

> Paul,
> On the off chance your reading this, I'll send a pseries
> patch on Monday, with luck (and some other patches too).
> I'm not touching any of the other plaforms, you and benh 
> would know those better.

Or rather Michael as he wrote the ppc MSI support. I'll check with him

Ben.



  parent reply	other threads:[~2007-10-20  1:30 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 21:36 [PATCH 5/7] pci: Export the pci_restore_msi_state() function Matt Carlson
2007-10-19 23:29 ` Linas Vepstas
2007-10-20  0:36   ` Michael Chan
2007-10-20  0:04     ` Linas Vepstas
2007-10-20  0:27       ` David Miller
2007-10-20  0:46         ` [BUG] powerpc does not save msi state [was " Linas Vepstas
2007-10-20  0:46           ` Linas Vepstas
2007-10-20  0:53           ` David Miller
2007-10-20  6:43             ` Michael Ellerman
2007-10-20  6:43               ` Michael Ellerman
2007-10-20 22:50               ` Michael Chan
2007-10-21 21:13               ` Benjamin Herrenschmidt
2007-10-21 21:13                 ` Benjamin Herrenschmidt
2007-10-22 19:54             ` Linas Vepstas
2007-10-22 19:54               ` Linas Vepstas
2007-10-23  0:23               ` David Miller
2007-10-23  0:23                 ` David Miller
2007-10-23  0:32                 ` Benjamin Herrenschmidt
2007-10-23  0:32                   ` Benjamin Herrenschmidt
2007-10-20  1:29           ` Benjamin Herrenschmidt [this message]
2007-10-20  1:29             ` Benjamin Herrenschmidt
2007-10-20  1:12       ` Michael Chan
2007-10-20  0:25         ` Linas Vepstas
2007-10-21 23:21 ` David Miller
2007-10-22  1:49   ` Michael Ellerman
2007-10-22  1:49     ` Michael Ellerman
2007-10-22 18:13     ` Linas Vepstas
2007-10-22 18:13       ` Linas Vepstas
2007-10-22 21:24       ` Benjamin Herrenschmidt
2007-10-22 21:24         ` Benjamin Herrenschmidt
2007-10-23  0:13         ` Linas Vepstas
2007-10-23  0:13           ` Linas Vepstas
2007-10-23  0:29           ` Benjamin Herrenschmidt
2007-10-23  0:29             ` Benjamin Herrenschmidt
2007-10-23  4:20       ` Michael Ellerman
2007-10-23  4:20         ` Michael Ellerman
2007-10-22  4:01   ` Michael Chan
2007-10-22  4:45     ` David Miller
2007-10-22 18:19       ` Linas Vepstas
2007-10-22 18:07   ` Linas Vepstas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1192843780.17235.17.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=ellerman@au1.ibm.com \
    --cc=linas@austin.ibm.com \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mcarlson@broadcom.com \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.