From: Avi Kivity <avi@qumranet.com>
To: kvm-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org,
Aurelien Jarno <aurelien@aurel32.net>,
Avi Kivity <avi@qumranet.com>
Subject: [PATCH 08/11] KVM: x86 emulator: fix access registers for instructions with ModR/M byte and Mod = 3
Date: Sun, 21 Oct 2007 13:08:09 +0200 [thread overview]
Message-ID: <11929648921167-git-send-email-avi@qumranet.com> (raw)
In-Reply-To: <1192964892617-git-send-email-avi@qumranet.com>
From: Aurelien Jarno <aurelien@aurel32.net>
The patch belows changes the access type to register from memory for
instructions that are declared as SrcMem or DstMem, but have a
ModR/M byte with Mod = 3.
It fixes (at least) the lmsw and smsw instructions on an AMD64 CPU,
which are needed for FreeBSD.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Avi Kivity <avi@qumranet.com>
---
drivers/kvm/x86_emulate.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index 0a8696d..a6ace30 100644
--- a/drivers/kvm/x86_emulate.c
+++ b/drivers/kvm/x86_emulate.c
@@ -825,6 +825,14 @@ done_prefixes:
if (twobyte && b == 0x01 && modrm_reg == 7)
break;
srcmem_common:
+ /*
+ * For instructions with a ModR/M byte, switch to register
+ * access if Mod = 3.
+ */
+ if ((d & ModRM) && modrm_mod == 3) {
+ src.type = OP_REG;
+ break;
+ }
src.type = OP_MEM;
src.ptr = (unsigned long *)cr2;
src.val = 0;
@@ -893,6 +901,14 @@ done_prefixes:
dst.ptr = (unsigned long *)cr2;
dst.bytes = (d & ByteOp) ? 1 : op_bytes;
dst.val = 0;
+ /*
+ * For instructions with a ModR/M byte, switch to register
+ * access if Mod = 3.
+ */
+ if ((d & ModRM) && modrm_mod == 3) {
+ dst.type = OP_REG;
+ break;
+ }
if (d & BitOp) {
unsigned long mask = ~(dst.bytes * 8 - 1);
--
1.5.3
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Aurelien Jarno <aurelien-rXXEIb44qovR7s880joybQ@public.gmane.org>
Subject: [PATCH 08/11] KVM: x86 emulator: fix access registers for instructions with ModR/M byte and Mod = 3
Date: Sun, 21 Oct 2007 13:08:09 +0200 [thread overview]
Message-ID: <11929648921167-git-send-email-avi@qumranet.com> (raw)
In-Reply-To: <1192964892617-git-send-email-avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
From: Aurelien Jarno <aurelien-rXXEIb44qovR7s880joybQ@public.gmane.org>
The patch belows changes the access type to register from memory for
instructions that are declared as SrcMem or DstMem, but have a
ModR/M byte with Mod = 3.
It fixes (at least) the lmsw and smsw instructions on an AMD64 CPU,
which are needed for FreeBSD.
Signed-off-by: Aurelien Jarno <aurelien-rXXEIb44qovR7s880joybQ@public.gmane.org>
Signed-off-by: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
---
drivers/kvm/x86_emulate.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index 0a8696d..a6ace30 100644
--- a/drivers/kvm/x86_emulate.c
+++ b/drivers/kvm/x86_emulate.c
@@ -825,6 +825,14 @@ done_prefixes:
if (twobyte && b == 0x01 && modrm_reg == 7)
break;
srcmem_common:
+ /*
+ * For instructions with a ModR/M byte, switch to register
+ * access if Mod = 3.
+ */
+ if ((d & ModRM) && modrm_mod == 3) {
+ src.type = OP_REG;
+ break;
+ }
src.type = OP_MEM;
src.ptr = (unsigned long *)cr2;
src.val = 0;
@@ -893,6 +901,14 @@ done_prefixes:
dst.ptr = (unsigned long *)cr2;
dst.bytes = (d & ByteOp) ? 1 : op_bytes;
dst.val = 0;
+ /*
+ * For instructions with a ModR/M byte, switch to register
+ * access if Mod = 3.
+ */
+ if ((d & ModRM) && modrm_mod == 3) {
+ dst.type = OP_REG;
+ break;
+ }
if (d & BitOp) {
unsigned long mask = ~(dst.bytes * 8 - 1);
--
1.5.3
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-21 11:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 11:08 [PATCH 00/11] KVM updates for Linux 2.6.24-rc review Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 01/11] KVM: x86 emulator: fix merge screwup due to emulator split Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 02/11] KVM: x86 emulator: fix repne/repnz decoding Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 03/11] KVM: MMU: Set shadow pte atomically in mmu_pte_write_zap_pte() Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 04/11] KVM: VMX: Handle NMIs before enabling interrupts and preemption Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 05/11] KVM: VMX: Reset mmu context when entering real mode Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 06/11] KVM: x86 emulator: implement 'movnti mem, reg' Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 07/11] KVM: VMX: Force vm86 mode if setting flags during real mode Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` Avi Kivity [this message]
2007-10-21 11:08 ` [PATCH 08/11] KVM: x86 emulator: fix access registers for instructions with ModR/M byte and Mod = 3 Avi Kivity
2007-10-21 11:08 ` [PATCH 09/11] KVM: Move kvm_guest_exit() after local_irq_enable() Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 10/11] KVM: Fix local apic timer divide by zero Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:08 ` [PATCH 11/11] KVM: Improve local apic timer wraparound handling Avi Kivity
2007-10-21 11:08 ` Avi Kivity
2007-10-21 11:12 ` [PATCH 00/11] KVM updates for Linux 2.6.24-rc review Avi Kivity
2007-10-21 11:12 ` Avi Kivity
2007-10-21 11:53 ` Laurent Vivier
2007-10-21 12:07 ` Avi Kivity
2007-10-21 12:07 ` Avi Kivity
2007-10-21 12:38 ` [kvm-devel] " Laurent Vivier
2007-10-22 9:36 ` Avi Kivity
2007-10-22 9:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11929648921167-git-send-email-avi@qumranet.com \
--to=avi@qumranet.com \
--cc=aurelien@aurel32.net \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.