All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	sparclinux@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c
Date: Tue, 23 Oct 2007 17:40:26 +1000	[thread overview]
Message-ID: <1193125226.6745.185.camel@pasglop> (raw)
In-Reply-To: <1193125016.20274.4.camel@concordia>


> So Ben suggested what we really want is two routines,
> of_get_pci_dev_node() and of_peek_pci_dev_node() - the former returning
> a refcounted copy and the latter allowing you to "peek" at the
> device_node as long as you own the pci_dev.
> 
> I'm not sure it's worth the churn really, so we should probably just
> document that pci_device_to_OF_node() is contrary, and any users that
> need a reference can take one explicitly.

Yeah, I pretty much made the same decision a couple of years ago which
is why it's still the way it is now :-)

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	sparclinux@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c
Date: Tue, 23 Oct 2007 07:40:26 +0000	[thread overview]
Message-ID: <1193125226.6745.185.camel@pasglop> (raw)
In-Reply-To: <1193125016.20274.4.camel@concordia>


> So Ben suggested what we really want is two routines,
> of_get_pci_dev_node() and of_peek_pci_dev_node() - the former returning
> a refcounted copy and the latter allowing you to "peek" at the
> device_node as long as you own the pci_dev.
> 
> I'm not sure it's worth the churn really, so we should probably just
> document that pci_device_to_OF_node() is contrary, and any users that
> need a reference can take one explicitly.

Yeah, I pretty much made the same decision a couple of years ago which
is why it's still the way it is now :-)

Cheers,
Ben.



  reply	other threads:[~2007-10-23  7:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17  7:12 [PATCH 1/2] Introduce of_get_pci_dev_node() Michael Ellerman
2007-10-17  7:12 ` [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c Michael Ellerman
2007-10-17 11:22   ` David Miller
2007-10-17 11:22     ` David Miller
2007-10-17 11:23     ` David Miller
2007-10-17 11:23       ` David Miller
2007-10-18  1:23       ` Michael Ellerman
2007-10-18  1:23         ` Michael Ellerman
2007-10-17 11:36     ` Benjamin Herrenschmidt
2007-10-17 11:36       ` Benjamin Herrenschmidt
2007-10-18  1:30       ` Michael Ellerman
2007-10-18  1:30         ` Michael Ellerman
2007-10-17 23:04   ` Linas Vepstas
2007-10-17 23:04     ` Linas Vepstas
2007-10-18  1:27     ` Michael Ellerman
2007-10-18  1:27       ` Michael Ellerman
2007-10-18 19:09       ` Linas Vepstas
2007-10-18 19:09         ` Linas Vepstas
2007-10-23  7:36         ` Michael Ellerman
2007-10-23  7:36           ` Michael Ellerman
2007-10-23  7:40           ` Benjamin Herrenschmidt [this message]
2007-10-23  7:40             ` Benjamin Herrenschmidt
2007-10-18  5:22     ` Stephen Rothwell
2007-10-18  5:22       ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193125226.6745.185.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=davem@davemloft.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.