From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: linux-ext4@vger.kernel.org
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH] ext4: Fix mballoc BUG when running compilebench
Date: Wed, 24 Oct 2007 22:17:18 +0530 [thread overview]
Message-ID: <1193244441-10149-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1193244441-10149-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
This fix the mballoc bug when running compile bench.
Instead of using direct division even though the arguments
are 32 bits we retain do_div. This would be needed if we
move to 64 bit logical block number.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
fs/ext4/mballoc.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index fe7cf9e..8467b3d 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -3089,13 +3089,14 @@ static void ext4_mb_normalize_request(struct ext4_allocation_context *ac,
}
}
if (wind == 0) {
+ __u64 tstart;
/* file is quite large, we now preallocate with
* the biggest configured window with regart to
* logical offset */
wind = sbi->s_mb_prealloc_table[i - 1];
- start = ac->ac_o_ex.fe_logical;
- do_div(start, wind);
- start = start * wind;
+ tstart = ac->ac_o_ex.fe_logical;
+ do_div(tstart, wind);
+ start = tstart * wind;
}
size = wind;
orig_size = size;
--
1.5.3.4.319.gdd817-dirty
next prev parent reply other threads:[~2007-10-24 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:47 Patches for review Aneesh Kumar K.V
2007-10-24 16:47 ` Aneesh Kumar K.V
2007-10-24 16:47 ` Aneesh Kumar K.V
2007-10-24 16:47 ` [PATCH] ext4: Change the default behaviour on error Aneesh Kumar K.V
2007-10-24 16:47 ` Aneesh Kumar K.V [this message]
2007-10-24 16:47 ` [PATCH] ext4: Enable delalloc and mballoc by default Aneesh Kumar K.V
2007-10-24 16:47 ` [PATCH] ext4: Show mballoc and delalloc options Aneesh Kumar K.V
2007-10-24 16:47 ` [PATCH] ext4: Fix ext4_show_options to show the correct mount options Aneesh Kumar K.V
2007-10-24 17:55 ` Eric Sandeen
2007-10-24 18:18 ` Aneesh Kumar K.V
2007-10-24 18:25 ` Eric Sandeen
2007-10-24 17:24 ` [PATCH] ext4: Show mballoc and delalloc options Eric Sandeen
2007-10-24 17:22 ` [PATCH] ext4: Enable delalloc and mballoc by default Eric Sandeen
2007-10-24 17:30 ` Aneesh Kumar K.V
2007-10-24 19:15 ` Mingming Cao
2007-10-24 21:06 ` Andreas Dilger
2007-10-24 21:15 ` Eric Sandeen
2007-10-24 22:59 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193244441-10149-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.