Re: [PATCH] ext4: Enable delalloc and mballoc by default.

[Eric Sandeen <sandeen@redhat.com>]

Aneesh Kumar K.V wrote:

> @@ -1279,6 +1280,9 @@ clear_qf_name:
>  		case Opt_delalloc:
>  			set_opt (sbi->s_mount_opt, DELALLOC);
>  			break;

If delalloc, mballoc, extents are the new defaults, is there a reason to
keep them as options?  When would you need to specify -o extents, now,
for example?  (though my brain is fuzzy today, maybe I'm missing
something)  If this were not a filesystem ending in "dev" I could see
keeping it for compatibility with existing fstabs....

> +		case Opt_nodelalloc:
> +			clear_opt (sbi->s_mount_opt, DELALLOC);
> +			break;
>  		case Opt_mballoc:
>  			set_opt(sbi->s_mount_opt, MBALLOC);
>  			break;
> @@ -1824,6 +1828,8 @@ static int ext4_fill_super (struct super_block *sb, void *data, int silent)
>  	 * User -o noextents to turn it off
>  	 */

I'd either update this comment ^^^^ or remove it, I think.

>  	set_opt(sbi->s_mount_opt, EXTENTS);
> +	set_opt(sbi->s_mount_opt, DELALLOC);
> +	set_opt(sbi->s_mount_opt, MBALLOC);
>  
>  	if (!parse_options ((char *) data, sb, &journal_inum, &journal_devnum,
>  			    NULL, 0))