From: Dave Hansen <haveblue@us.ibm.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
anton@au1.ibm.com, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 1/3] Add remove_memory() for ppc64
Date: Wed, 31 Oct 2007 13:45:02 -0700 [thread overview]
Message-ID: <1193863502.6271.38.camel@localhost> (raw)
In-Reply-To: <1193849375.17412.34.camel@dyn9047017100.beaverton.ibm.com>
On Wed, 2007-10-31 at 08:49 -0800, Badari Pulavarty wrote:
> +#ifdef CONFIG_MEMORY_HOTREMOVE
> +int remove_memory(u64 start, u64 size)
> +{
> + unsigned long start_pfn, end_pfn;
> + unsigned long timeout = 120 * HZ;
> + int ret;
> + start_pfn = start >> PAGE_SHIFT;
> + end_pfn = start_pfn + (size >> PAGE_SHIFT);
> + ret = offline_pages(start_pfn, end_pfn, timeout);
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(remove_memory);
> +#endif /* CONFIG_MEMORY_HOTREMOVE */
Did someone go and copy the ia64 verion? Tsk. Tsk. Bad Badari. :)
Can we just make this a weak symbol in the generic mm/memory_hotplug.c?
Or, make this the generic memory_remove() function int there and have an
arch_remove_memory() hook called from there if the architectures need to
tweak it?
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@ozlabs.org, anton@au1.ibm.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 1/3] Add remove_memory() for ppc64
Date: Wed, 31 Oct 2007 13:45:02 -0700 [thread overview]
Message-ID: <1193863502.6271.38.camel@localhost> (raw)
In-Reply-To: <1193849375.17412.34.camel@dyn9047017100.beaverton.ibm.com>
On Wed, 2007-10-31 at 08:49 -0800, Badari Pulavarty wrote:
> +#ifdef CONFIG_MEMORY_HOTREMOVE
> +int remove_memory(u64 start, u64 size)
> +{
> + unsigned long start_pfn, end_pfn;
> + unsigned long timeout = 120 * HZ;
> + int ret;
> + start_pfn = start >> PAGE_SHIFT;
> + end_pfn = start_pfn + (size >> PAGE_SHIFT);
> + ret = offline_pages(start_pfn, end_pfn, timeout);
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(remove_memory);
> +#endif /* CONFIG_MEMORY_HOTREMOVE */
Did someone go and copy the ia64 verion? Tsk. Tsk. Bad Badari. :)
Can we just make this a weak symbol in the generic mm/memory_hotplug.c?
Or, make this the generic memory_remove() function int there and have an
arch_remove_memory() hook called from there if the architectures need to
tweak it?
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-31 20:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 16:49 [PATCH 1/3] Add remove_memory() for ppc64 Badari Pulavarty
2007-10-31 16:49 ` Badari Pulavarty
2007-10-31 20:45 ` Dave Hansen [this message]
2007-10-31 20:45 ` Dave Hansen
2007-10-31 22:11 ` Badari Pulavarty
2007-10-31 22:11 ` Badari Pulavarty
2007-10-31 21:55 ` Dave Hansen
2007-10-31 21:55 ` Dave Hansen
2007-11-01 0:46 ` KAMEZAWA Hiroyuki
2007-11-01 0:46 ` KAMEZAWA Hiroyuki
2007-10-31 22:13 ` Badari Pulavarty
2007-10-31 22:13 ` Badari Pulavarty
2007-11-01 6:26 ` Kumar Gala
2007-11-01 6:26 ` Kumar Gala
2007-10-31 21:45 ` Badari Pulavarty
2007-10-31 21:45 ` Badari Pulavarty
2007-10-31 21:47 ` Dale Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193863502.6271.38.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anton@au1.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=pbadari@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.