All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] add DID_REQUEUE string to scsi_show_result host table
@ 2007-11-01  1:59 Mike Christie
  0 siblings, 0 replies; only message in thread
From: Mike Christie @ 2007-11-01  1:59 UTC (permalink / raw)
  To: linux-scsi

I was working on patches which add new transport error values, when I
noticed that DID_REQUEUE was not in the hostbyte_table. I do not think
there is any way to hit the code path where scsi_show_result is called
and where you return DID_REQUEUE, because DID_REQUEUE causes scsi-ml to
always requeue the command. However, for completeness and because I want
to one day send a patch that tries to add new host bytes values, I am
sending this patch.

Please apply when you get a chance. It is not critical.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>


--- linux-2.6.23/drivers/scsi/constants.c.orig	2007-10-31 20:49:47.000000000 -0500
+++ linux-2.6.23/drivers/scsi/constants.c	2007-10-31 20:50:14.000000000 -0500
@@ -1355,7 +1355,7 @@ EXPORT_SYMBOL(scsi_print_sense);
 static const char * const hostbyte_table[]={
 "DID_OK", "DID_NO_CONNECT", "DID_BUS_BUSY", "DID_TIME_OUT", "DID_BAD_TARGET",
 "DID_ABORT", "DID_PARITY", "DID_ERROR", "DID_RESET", "DID_BAD_INTR",
-"DID_PASSTHROUGH", "DID_SOFT_ERROR", "DID_IMM_RETRY"};
+"DID_PASSTHROUGH", "DID_SOFT_ERROR", "DID_IMM_RETRY", "DID_REQUEUE"};
 #define NUM_HOSTBYTE_STRS ARRAY_SIZE(hostbyte_table)
 
 static const char * const driverbyte_table[]={




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-11-01  1:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-01  1:59 [PATCH] add DID_REQUEUE string to scsi_show_result host table Mike Christie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.