From: Marcel Holtmann <marcel@holtmann.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: bluez-devel@lists.sourceforge.net,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [Bluez-devel] [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device
Date: Thu, 01 Nov 2007 05:56:50 +0100 [thread overview]
Message-ID: <1193893010.32459.104.camel@violet> (raw)
In-Reply-To: <a8e1da0710311920sa7db787s604f154f201d3a1@mail.gmail.com>
Hi Dave,
> > > Maybe we can use this instead:
> > > > snprintf(conn->dev.bus_id, BUS_ID_SIZE,
> > > > - "%s%2.2X%2.2X%2.2X%2.2X%2.2X%2.2X",
> > > > + "%s%s%2.2X%2.2X%2.2X%2.2X%2.2X%2.2X",
> > > > + hdev->name + 3,
> > > > conn->type == ACL_LINK ? "acl" : "sco",
> > > > ba->b[5], ba->b[4], ba->b[3],
> > > > ba->b[2], ba->b[1], ba->b[0]);
> > >
> > > I had a look on how other subsystems handle this case and yes, they
> > > duplicate the id number from its parent device. So I applied the
> > > attached patch to my tree.
>
> Sorry for my noise.
> Theoretically, for the "%d-%s" version, overwrite is also possible.
>
> hdev->id is u16, imagine the id is 65535, then total length is 21.
even to reach 3 digits you have to attach 100 Bluetooth devices at the
same time. Tell me when you have done that ;)
However, as I said, we have to move to using the connection handle.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
WARNING: multiple messages have this Message-ID (diff)
From: Marcel Holtmann <marcel@holtmann.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, bluez-devel@lists.sourceforge.net
Subject: Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device
Date: Thu, 01 Nov 2007 05:56:50 +0100 [thread overview]
Message-ID: <1193893010.32459.104.camel@violet> (raw)
In-Reply-To: <a8e1da0710311920sa7db787s604f154f201d3a1@mail.gmail.com>
Hi Dave,
> > > Maybe we can use this instead:
> > > > snprintf(conn->dev.bus_id, BUS_ID_SIZE,
> > > > - "%s%2.2X%2.2X%2.2X%2.2X%2.2X%2.2X",
> > > > + "%s%s%2.2X%2.2X%2.2X%2.2X%2.2X%2.2X",
> > > > + hdev->name + 3,
> > > > conn->type == ACL_LINK ? "acl" : "sco",
> > > > ba->b[5], ba->b[4], ba->b[3],
> > > > ba->b[2], ba->b[1], ba->b[0]);
> > >
> > > I had a look on how other subsystems handle this case and yes, they
> > > duplicate the id number from its parent device. So I applied the
> > > attached patch to my tree.
>
> Sorry for my noise.
> Theoretically, for the "%d-%s" version, overwrite is also possible.
>
> hdev->id is u16, imagine the id is 65535, then total length is 21.
even to reach 3 digits you have to attach 100 Bluetooth devices at the
same time. Tell me when you have done that ;)
However, as I said, we have to move to using the connection handle.
Regards
Marcel
next prev parent reply other threads:[~2007-11-01 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 2:30 [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device Dave Young
2007-10-31 7:01 ` David Miller
2007-10-31 7:56 ` [Bluez-devel] " Marcel Holtmann
2007-10-31 7:56 ` Marcel Holtmann
2007-10-31 9:13 ` Dave Young
2007-10-31 9:59 ` [Bluez-devel] " Marcel Holtmann
2007-10-31 9:59 ` Marcel Holtmann
2007-11-01 1:05 ` Dave Young
2007-11-01 2:20 ` Dave Young
2007-11-01 4:56 ` Marcel Holtmann [this message]
2007-11-01 4:56 ` Marcel Holtmann
2007-10-31 9:06 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193893010.32459.104.camel@violet \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.