From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linux-pm <linux-pm@lists.linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [RFC] powermac: proper sleep management
Date: Mon, 12 Nov 2007 07:59:33 +1100 [thread overview]
Message-ID: <1194814773.6510.23.camel@pasglop> (raw)
In-Reply-To: <1194523729.6294.18.camel@johannes.berg>
> Just thought I'd send out the patch again, it has changed quite a bit
> since last time because I cleaned up the code, made it depend on
> CONFIG_SUSPEND, made the ioctl backward compatibility optional and some
> other bits.
>
> The feared freezer vs. fuse sync deadlock is no longer present in 2.6.24
> because the sync is done before the freezer so maybe the patch stands a
> chance now.
>
> Scott: FYI, here's the use case for the ppc_md irq suspend/resume hooks.
Looks good to me, +/- a couple of things:
- We _REALLY_ want the freezer to be optional and not enabled by
default on PowerPC. Maybe make it a compile option ?
- Don't remove the pmu_polled_request() debug code. It's very useful
for debugging and I don't want to have to re-invent it.
Plus I also need to test it on some exotic hardware :-)
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
linux-pm <linux-pm@lists.linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC] powermac: proper sleep management
Date: Mon, 12 Nov 2007 07:59:33 +1100 [thread overview]
Message-ID: <1194814773.6510.23.camel@pasglop> (raw)
In-Reply-To: <1194523729.6294.18.camel@johannes.berg>
> Just thought I'd send out the patch again, it has changed quite a bit
> since last time because I cleaned up the code, made it depend on
> CONFIG_SUSPEND, made the ioctl backward compatibility optional and some
> other bits.
>
> The feared freezer vs. fuse sync deadlock is no longer present in 2.6.24
> because the sync is done before the freezer so maybe the patch stands a
> chance now.
>
> Scott: FYI, here's the use case for the ppc_md irq suspend/resume hooks.
Looks good to me, +/- a couple of things:
- We _REALLY_ want the freezer to be optional and not enabled by
default on PowerPC. Maybe make it a compile option ?
- Don't remove the pmu_polled_request() debug code. It's very useful
for debugging and I don't want to have to re-invent it.
Plus I also need to test it on some exotic hardware :-)
Cheers,
Ben.
next prev parent reply other threads:[~2007-11-11 20:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 12:08 [RFC] powermac: proper sleep management Johannes Berg
2007-11-08 12:08 ` Johannes Berg
2007-11-08 19:15 ` Scott Wood
2007-11-08 19:15 ` Scott Wood
2007-11-08 23:19 ` Benjamin Herrenschmidt
2007-11-08 23:19 ` Benjamin Herrenschmidt
2007-11-11 13:35 ` Pavel Machek
2007-11-11 13:35 ` [linux-pm] " Pavel Machek
2007-11-11 20:59 ` Benjamin Herrenschmidt [this message]
2007-11-11 20:59 ` Benjamin Herrenschmidt
2007-11-12 16:32 ` Johannes Berg
2007-11-12 19:52 ` Alan Stern
2007-11-12 19:52 ` [linux-pm] " Alan Stern
2007-11-13 13:19 ` Johannes Berg
2007-11-13 13:19 ` Johannes Berg
2007-11-12 20:24 ` Benjamin Herrenschmidt
2007-11-12 20:24 ` Benjamin Herrenschmidt
2007-11-12 20:40 ` [linux-pm] " Alan Stern
2007-11-12 20:56 ` Benjamin Herrenschmidt
2007-11-12 20:56 ` [linux-pm] " Benjamin Herrenschmidt
2007-11-12 21:52 ` Alan Stern
2007-11-12 21:52 ` Alan Stern
2007-11-12 20:40 ` Alan Stern
2007-11-12 16:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194814773.6510.23.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.