From: Yuri Tikhonov <yur@emcraft.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-raid@vger.kernel.org, linuxppc-dev@ozlabs.org, dzu@denx.de,
wd@denx.de, yanok@emcraft.com
Subject: Re[2]: [PATCH 01/11] async_tx: don't use src_list argument of async_xor() for dma addresses
Date: Tue, 9 Dec 2008 03:41:36 +0300 [thread overview]
Message-ID: <1195158776.20081209034136@emcraft.com> (raw)
In-Reply-To: <e9c3a7c20812081631i1e0efff2j953b2e81f6dc6e0e@mail.gmail.com>
On Tuesday, December 9, 2008 you wrote:
> On Mon, Dec 8, 2008 at 2:55 PM, Yuri Tikhonov <yur@emcraft.com> wrote:
>> Using src_list argument of async_xor() as a storage for dma addresses
>> implies sizeof(dma_addr_t) <= sizeof(struct page *) restriction which is
>> not always true (e.g. ppc440spe).
>>
> ppc440spe runs with CONFIG_PHYS_64BIT?
Yep. It uses 36-bit addressing, so this CONFIG is turned on.
> If we do this then we need to also change md to limit the number of
> allowed disks based on the kernel stack size. Because with 256 disks
> a 4K stack can be consumed by one call to async_pq ((256 sources in
> raid5.c + 256 sources async_pq.c) * 8 bytes per source on 64-bit).
On ppc440spe we have 8KB stack, so the things are not worse than on
32-bit archs with 4KB stack. Thus, I guess no changes to md are
required because of this patch. Right?
Regards, Yuri
--
Yuri Tikhonov, Senior Software Engineer
Emcraft Systems, www.emcraft.com
WARNING: multiple messages have this Message-ID (diff)
From: Yuri Tikhonov <yur@emcraft.com>
To: "Dan Williams" <dan.j.williams@intel.com>
Cc: linux-raid@vger.kernel.org, linuxppc-dev@ozlabs.org, wd@denx.de,
dzu@denx.de, yanok@emcraft.com
Subject: Re[2]: [PATCH 01/11] async_tx: don't use src_list argument of async_xor() for dma addresses
Date: Tue, 9 Dec 2008 03:41:36 +0300 [thread overview]
Message-ID: <1195158776.20081209034136@emcraft.com> (raw)
In-Reply-To: <e9c3a7c20812081631i1e0efff2j953b2e81f6dc6e0e@mail.gmail.com>
On Tuesday, December 9, 2008 you wrote:
> On Mon, Dec 8, 2008 at 2:55 PM, Yuri Tikhonov <yur@emcraft.com> wrote:
>> Using src_list argument of async_xor() as a storage for dma addresses
>> implies sizeof(dma_addr_t) <=3D sizeof(struct page *) restriction which =
is
>> not always true (e.g. ppc440spe).
>>
> ppc440spe runs with CONFIG_PHYS_64BIT?
Yep. It uses 36-bit addressing, so this CONFIG is turned on.
> If we do this then we need to also change md to limit the number of
> allowed disks based on the kernel stack size. Because with 256 disks
> a 4K stack can be consumed by one call to async_pq ((256 sources in
> raid5.c + 256 sources async_pq.c) * 8 bytes per source on 64-bit).
On ppc440spe we have 8KB stack, so the things are not worse than on=20
32-bit archs with 4KB stack. Thus, I guess no changes to md are=20
required because of this patch. Right?
Regards, Yuri
--
Yuri Tikhonov, Senior Software Engineer
Emcraft Systems, www.emcraft.com
next prev parent reply other threads:[~2008-12-09 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 21:55 [PATCH 01/11] async_tx: don't use src_list argument of async_xor() for dma addresses Yuri Tikhonov
2008-12-08 21:55 ` Yuri Tikhonov
2008-12-09 0:31 ` Dan Williams
2008-12-09 0:31 ` Dan Williams
2008-12-09 0:41 ` Yuri Tikhonov [this message]
2008-12-09 0:41 ` Re[2]: " Yuri Tikhonov
2008-12-10 1:08 ` Dan Williams
2008-12-10 1:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195158776.20081209034136@emcraft.com \
--to=yur@emcraft.com \
--cc=dan.j.williams@intel.com \
--cc=dzu@denx.de \
--cc=linux-raid@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.