All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Haupt <andre@bitwigglers.org>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, drzeus-mmc@drzeus.cx,
	nico@cam.org, Andre Haupt <andre@bitwigglers.org>
Subject: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()
Date: Wed, 21 Nov 2007 11:33:45 +0000	[thread overview]
Message-ID: <11956448251191-git-send-email-andre@bitwigglers.org> (raw)
In-Reply-To: n

I think, the status paramter should be unsigned. Is this correct?
This also fixes a sparse warning about different signedness.
Only compile tested, because i do not have the hardware.

From: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
---
 drivers/mmc/card/sdio_uart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/card/sdio_uart.c b/drivers/mmc/card/sdio_uart.c
index d552de6..eeea84c 100644
--- a/drivers/mmc/card/sdio_uart.c
+++ b/drivers/mmc/card/sdio_uart.c
@@ -386,7 +386,7 @@ static void sdio_uart_stop_rx(struct sdio_uart_port *port)
 	sdio_out(port, UART_IER, port->ier);
 }
 
-static void sdio_uart_receive_chars(struct sdio_uart_port *port, int *status)
+static void sdio_uart_receive_chars(struct sdio_uart_port *port, unsigned int *status)
 {
 	struct tty_struct *tty = port->tty;
 	unsigned int ch, flag;
-- 
1.4.4.4


WARNING: multiple messages have this Message-ID (diff)
From: Andre Haupt <andre@bitwigglers.org>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, drzeus-mmc@drzeus.cx,
	nico@cam.org, Andre Haupt <andre@bitwigglers.org>
Subject: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()
Date: Wed, 21 Nov 2007 12:33:45 +0100	[thread overview]
Message-ID: <11956448251191-git-send-email-andre@bitwigglers.org> (raw)
In-Reply-To: n

I think, the status paramter should be unsigned. Is this correct?
This also fixes a sparse warning about different signedness.
Only compile tested, because i do not have the hardware.

From: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
---
 drivers/mmc/card/sdio_uart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/card/sdio_uart.c b/drivers/mmc/card/sdio_uart.c
index d552de6..eeea84c 100644
--- a/drivers/mmc/card/sdio_uart.c
+++ b/drivers/mmc/card/sdio_uart.c
@@ -386,7 +386,7 @@ static void sdio_uart_stop_rx(struct sdio_uart_port *port)
 	sdio_out(port, UART_IER, port->ier);
 }
 
-static void sdio_uart_receive_chars(struct sdio_uart_port *port, int *status)
+static void sdio_uart_receive_chars(struct sdio_uart_port *port, unsigned int *status)
 {
 	struct tty_struct *tty = port->tty;
 	unsigned int ch, flag;
-- 
1.4.4.4


             reply	other threads:[~2007-11-21 11:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 11:33 Andre Haupt [this message]
2007-11-21 11:33 ` [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars() Andre Haupt
2007-11-24 14:36 ` [PATCH] sdio_uart: fix sign of paramter status in Pierre Ossman
2007-11-24 14:36   ` [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars() Pierre Ossman
2007-11-24 15:35   ` [PATCH] sdio_uart: fix sign of paramter status in Nicolas Pitre
2007-11-24 15:35     ` [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars() Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11956448251191-git-send-email-andre@bitwigglers.org \
    --to=andre@bitwigglers.org \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.