From: Hollis Blanchard <hollisb@us.ibm.com>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [kvm-ppc-devel] [kvm-devel] [PATCH] RFC: Use CONFIG_HAS_IOPORT
Date: Tue, 04 Dec 2007 04:24:04 +0000 [thread overview]
Message-ID: <1196742244.23391.4.camel@basalt> (raw)
In-Reply-To: <b7ee515965e969287497.1196720061@basalt>
Actually, (now that I try to build with it :) this doesn't work for
PowerPC, which defines (or rather, doesn't not define)
CONFIG_HAS_IOPORT.
So I guess a callout to arch code will do. I'll send a patch sometime.
--
Hollis Blanchard
IBM Linux Technology Center
On Mon, 2007-12-03 at 16:14 -0600, Hollis Blanchard wrote:
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> ---
> pio_data is obviously arch-specific, but we might be able to get by with an
> ifdef in kvm_vcpu_nopage() rather than needing an arch hook. Thoughts?
>
> 1 file changed, 2 insertions(+)
> drivers/kvm/kvm_main.c | 2 ++
>
>
> diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
> --- a/drivers/kvm/kvm_main.c
> +++ b/drivers/kvm/kvm_main.c
> @@ -674,8 +674,10 @@ static struct page *kvm_vcpu_nopage(stru
> pgoff = ((address - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
> if (pgoff = 0)
> page = virt_to_page(vcpu->run);
> +#ifdef CONFIG_HAS_IOPORT
> else if (pgoff = KVM_PIO_PAGE_OFFSET)
> page = virt_to_page(vcpu->pio_data);
> +#endif /* CONFIG_HAS_IOPORT */
> else
> return NOPAGE_SIGBUS;
> get_page(page);
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell. From the desktop to the data center, Linux is going
> mainstream. Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel
WARNING: multiple messages have this Message-ID (diff)
From: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] RFC: Use CONFIG_HAS_IOPORT around vcpu->pio_data
Date: Mon, 03 Dec 2007 22:24:04 -0600 [thread overview]
Message-ID: <1196742244.23391.4.camel@basalt> (raw)
In-Reply-To: <b7ee515965e969287497.1196720061@basalt>
Actually, (now that I try to build with it :) this doesn't work for
PowerPC, which defines (or rather, doesn't not define)
CONFIG_HAS_IOPORT.
So I guess a callout to arch code will do. I'll send a patch sometime.
--
Hollis Blanchard
IBM Linux Technology Center
On Mon, 2007-12-03 at 16:14 -0600, Hollis Blanchard wrote:
> Signed-off-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> pio_data is obviously arch-specific, but we might be able to get by with an
> ifdef in kvm_vcpu_nopage() rather than needing an arch hook. Thoughts?
>
> 1 file changed, 2 insertions(+)
> drivers/kvm/kvm_main.c | 2 ++
>
>
> diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
> --- a/drivers/kvm/kvm_main.c
> +++ b/drivers/kvm/kvm_main.c
> @@ -674,8 +674,10 @@ static struct page *kvm_vcpu_nopage(stru
> pgoff = ((address - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
> if (pgoff == 0)
> page = virt_to_page(vcpu->run);
> +#ifdef CONFIG_HAS_IOPORT
> else if (pgoff == KVM_PIO_PAGE_OFFSET)
> page = virt_to_page(vcpu->pio_data);
> +#endif /* CONFIG_HAS_IOPORT */
> else
> return NOPAGE_SIGBUS;
> get_page(page);
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell. From the desktop to the data center, Linux is going
> mainstream. Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________
> kvm-devel mailing list
> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
next prev parent reply other threads:[~2007-12-04 4:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 22:14 [kvm-ppc-devel] [PATCH] RFC: Use CONFIG_HAS_IOPORT around Hollis Blanchard
2007-12-03 22:14 ` [PATCH] RFC: Use CONFIG_HAS_IOPORT around vcpu->pio_data Hollis Blanchard
2007-12-04 4:24 ` Hollis Blanchard [this message]
2007-12-04 4:24 ` Hollis Blanchard
2007-12-04 4:39 ` [kvm-ppc-devel] [kvm-devel] [PATCH] RFC: Use Zhang, Xiantao
2007-12-04 4:39 ` [kvm-ppc-devel] [PATCH] RFC: Use CONFIG_HAS_IOPORTaround vcpu->pio_data Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA39EA6-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-12-04 4:49 ` [kvm-ppc-devel] [kvm-devel] [PATCH] RFC: Hollis Blanchard
2007-12-04 4:49 ` [kvm-ppc-devel] [PATCH] RFC: Use CONFIG_HAS_IOPORTaround vcpu->pio_data Hollis Blanchard
2007-12-04 5:04 ` [kvm-ppc-devel] [kvm-devel] [PATCH] RFC: Zhang, Xiantao
2007-12-04 5:04 ` [kvm-ppc-devel] [PATCH] RFC: UseCONFIG_HAS_IOPORTaround vcpu->pio_data Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA39EC1-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-12-04 5:53 ` [kvm-ppc-devel] [kvm-devel] [PATCH] Hollis Blanchard
2007-12-04 5:53 ` [kvm-ppc-devel] [PATCH] RFC: UseCONFIG_HAS_IOPORTaround vcpu->pio_data Hollis Blanchard
2007-12-04 9:24 ` [kvm-ppc-devel] [kvm-devel] [PATCH] Dong, Eddie
2007-12-04 9:24 ` [kvm-ppc-devel] [PATCH] RFC:Use CONFIG_HAS_IOPORTaround vcpu->pio_data Dong, Eddie
2007-12-04 10:48 ` [kvm-ppc-devel] [kvm-devel] [PATCH] RFC: Use CONFIG_HAS_IOPORT Avi Kivity
2007-12-04 10:48 ` [PATCH] RFC: Use CONFIG_HAS_IOPORT around vcpu->pio_data Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196742244.23391.4.camel@basalt \
--to=hollisb@us.ibm.com \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.