From: Andre Haupt <andre@bitwigglers.org>
To: kernel-janitors@vger.kernel.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@kernel.org, Andre Haupt <andre@bitwigglers.org>
Subject: [PATCH][KJ] 8250: remove unnecessary variable tmout from wait_for_xmitr()
Date: Thu, 13 Dec 2007 14:08:04 +0000 [thread overview]
Message-ID: <11975548843528-git-send-email-andre@bitwigglers.org> (raw)
In-Reply-To: n
This fixes a sparse warning about symbol tmout shadowing an earlier one.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
---
drivers/serial/8250.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index f94109c..284757d 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -1727,7 +1727,6 @@ static inline void wait_for_xmitr(struct uart_8250_port *up, int bits)
/* Wait up to 1s for flow control if necessary */
if (up->port.flags & UPF_CONS_FLOW) {
- unsigned int tmout;
for (tmout = 1000000; tmout; tmout--) {
unsigned int msr = serial_in(up, UART_MSR);
up->msr_saved_flags |= msr & MSR_SAVE_FLAGS;
--
1.4.4.4
WARNING: multiple messages have this Message-ID (diff)
From: Andre Haupt <andre@bitwigglers.org>
To: kernel-janitors@vger.kernel.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
trivial@kernel.org, Andre Haupt <andre@bitwigglers.org>
Subject: [PATCH][KJ] 8250: remove unnecessary variable tmout from wait_for_xmitr()
Date: Thu, 13 Dec 2007 15:08:04 +0100 [thread overview]
Message-ID: <11975548843528-git-send-email-andre@bitwigglers.org> (raw)
In-Reply-To: n
This fixes a sparse warning about symbol tmout shadowing an earlier one.
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
---
drivers/serial/8250.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index f94109c..284757d 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -1727,7 +1727,6 @@ static inline void wait_for_xmitr(struct uart_8250_port *up, int bits)
/* Wait up to 1s for flow control if necessary */
if (up->port.flags & UPF_CONS_FLOW) {
- unsigned int tmout;
for (tmout = 1000000; tmout; tmout--) {
unsigned int msr = serial_in(up, UART_MSR);
up->msr_saved_flags |= msr & MSR_SAVE_FLAGS;
--
1.4.4.4
next reply other threads:[~2007-12-13 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 14:08 Andre Haupt [this message]
2007-12-13 14:08 ` [PATCH][KJ] 8250: remove unnecessary variable tmout from wait_for_xmitr() Andre Haupt
2007-12-13 14:51 ` Johannes Weiner
2007-12-13 14:51 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11975548843528-git-send-email-andre@bitwigglers.org \
--to=andre@bitwigglers.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.