All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arch/arm/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-17 19:30 ` [PATCH] include/asm-arm/: " Joe Perches
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Lennert Buytenhek, Richard Purdie


Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/arm/mach-pxa/corgi_ssp.c    |    2 +-
 arch/arm/mach-sa1100/collie_pm.c |    2 +-
 arch/arm/plat-s3c24xx/irq.c      |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-pxa/corgi_ssp.c b/arch/arm/mach-pxa/corgi_ssp.c
index 40dea3d..a6f2105 100644
--- a/arch/arm/mach-pxa/corgi_ssp.c
+++ b/arch/arm/mach-pxa/corgi_ssp.c
@@ -31,7 +31,7 @@ static struct corgissp_machinfo *ssp_machinfo;
 /*
  * There are three devices connected to the SSP interface:
  *   1. A touchscreen controller (TI ADS7846 compatible)
- *   2. An LCD contoller (with some Backlight functionality)
+ *   2. An LCD controller (with some Backlight functionality)
  *   3. A battery monitoring IC (Maxim MAX1111)
  *
  * Each device uses a different speed/mode of communication.
diff --git a/arch/arm/mach-sa1100/collie_pm.c b/arch/arm/mach-sa1100/collie_pm.c
index 1e25b1d..94620be 100644
--- a/arch/arm/mach-sa1100/collie_pm.c
+++ b/arch/arm/mach-sa1100/collie_pm.c
@@ -165,7 +165,7 @@ int collie_read_temp(void)
 
 	ucb1x00_adc_enable(ucb);
 	ucb1x00_io_write(ucb, COLLIE_TC35143_GPIO_TMP_ON, 0);
-	/* >1010 = battery removed, 460 = 22C ?, higer = lower temp ? */
+	/* >1010 = battery removed, 460 = 22C ?, higher = lower temp ? */
 	voltage = ucb1x00_adc_read(ucb, UCB_ADC_INP_AD0, UCB_SYNC);
 	ucb1x00_io_write(ucb, 0, COLLIE_TC35143_GPIO_TMP_ON);
 	ucb1x00_adc_disable(ucb);
diff --git a/arch/arm/plat-s3c24xx/irq.c b/arch/arm/plat-s3c24xx/irq.c
index 8fbc884..194821e 100644
--- a/arch/arm/plat-s3c24xx/irq.c
+++ b/arch/arm/plat-s3c24xx/irq.c
@@ -47,7 +47,7 @@
  *		  Mark IRQ_LCD valid
  *
  *   25-Jul-2005  Ben Dooks
- *		  Split the S3C2440 IRQ code to seperate file
+ *		  Split the S3C2440 IRQ code to separate file
 */
 
 #include <linux/init.h>
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
  2007-12-17 19:30 ` [PATCH] arch/arm/: " Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-17 19:30 ` [PATCH] arch/blackfin/: " Joe Perches
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Dirk Opfer, Lennert Buytenhek, Richard Purdie


Signed-off-by: Joe Perches <joe@perches.com>
---
 include/asm-arm/arch-ixp4xx/ixp4xx-regs.h |   34 +++++++++++++-------------
 include/asm-arm/arch-pxa/pxa-regs.h       |   36 ++++++++++++++--------------
 include/asm-arm/hardware/it8152.h         |    2 +-
 include/asm-arm/mach/udc_pxa2xx.h         |    2 +-
 4 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h b/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h
index 5d949d7..1205c28 100644
--- a/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h
+++ b/include/asm-arm/arch-ixp4xx/ixp4xx-regs.h
@@ -587,23 +587,23 @@
 #define UICR1_IM14	(1 << 6)	/* Interrupt mask ep 14 */
 #define UICR1_IM15	(1 << 7)	/* Interrupt mask ep 15 */
 
-#define USIR0_IR0	(1 << 0)	/* Interrup request ep 0 */
-#define USIR0_IR1	(1 << 1)	/* Interrup request ep 1 */
-#define USIR0_IR2	(1 << 2)	/* Interrup request ep 2 */
-#define USIR0_IR3	(1 << 3)	/* Interrup request ep 3 */
-#define USIR0_IR4	(1 << 4)	/* Interrup request ep 4 */
-#define USIR0_IR5	(1 << 5)	/* Interrup request ep 5 */
-#define USIR0_IR6	(1 << 6)	/* Interrup request ep 6 */
-#define USIR0_IR7	(1 << 7)	/* Interrup request ep 7 */
-
-#define USIR1_IR8	(1 << 0)	/* Interrup request ep 8 */
-#define USIR1_IR9	(1 << 1)	/* Interrup request ep 9 */
-#define USIR1_IR10	(1 << 2)	/* Interrup request ep 10 */
-#define USIR1_IR11	(1 << 3)	/* Interrup request ep 11 */
-#define USIR1_IR12	(1 << 4)	/* Interrup request ep 12 */
-#define USIR1_IR13	(1 << 5)	/* Interrup request ep 13 */
-#define USIR1_IR14	(1 << 6)	/* Interrup request ep 14 */
-#define USIR1_IR15	(1 << 7)	/* Interrup request ep 15 */
+#define USIR0_IR0	(1 << 0)	/* Interrupt request ep 0 */
+#define USIR0_IR1	(1 << 1)	/* Interrupt request ep 1 */
+#define USIR0_IR2	(1 << 2)	/* Interrupt request ep 2 */
+#define USIR0_IR3	(1 << 3)	/* Interrupt request ep 3 */
+#define USIR0_IR4	(1 << 4)	/* Interrupt request ep 4 */
+#define USIR0_IR5	(1 << 5)	/* Interrupt request ep 5 */
+#define USIR0_IR6	(1 << 6)	/* Interrupt request ep 6 */
+#define USIR0_IR7	(1 << 7)	/* Interrupt request ep 7 */
+
+#define USIR1_IR8	(1 << 0)	/* Interrupt request ep 8 */
+#define USIR1_IR9	(1 << 1)	/* Interrupt request ep 9 */
+#define USIR1_IR10	(1 << 2)	/* Interrupt request ep 10 */
+#define USIR1_IR11	(1 << 3)	/* Interrupt request ep 11 */
+#define USIR1_IR12	(1 << 4)	/* Interrupt request ep 12 */
+#define USIR1_IR13	(1 << 5)	/* Interrupt request ep 13 */
+#define USIR1_IR14	(1 << 6)	/* Interrupt request ep 14 */
+#define USIR1_IR15	(1 << 7)	/* Interrupt request ep 15 */
 
 #define DCMD_LENGTH	0x01fff		/* length mask (max = 8K - 1) */
 
diff --git a/include/asm-arm/arch-pxa/pxa-regs.h b/include/asm-arm/arch-pxa/pxa-regs.h
index 6b33df6..7a110a0 100644
--- a/include/asm-arm/arch-pxa/pxa-regs.h
+++ b/include/asm-arm/arch-pxa/pxa-regs.h
@@ -737,25 +737,25 @@
 
 #define USIR0		__REG(0x40600058)  /* UDC Status Interrupt Register 0 */
 
-#define USIR0_IR0	(1 << 0)	/* Interrup request ep 0 */
-#define USIR0_IR1	(1 << 1)	/* Interrup request ep 1 */
-#define USIR0_IR2	(1 << 2)	/* Interrup request ep 2 */
-#define USIR0_IR3	(1 << 3)	/* Interrup request ep 3 */
-#define USIR0_IR4	(1 << 4)	/* Interrup request ep 4 */
-#define USIR0_IR5	(1 << 5)	/* Interrup request ep 5 */
-#define USIR0_IR6	(1 << 6)	/* Interrup request ep 6 */
-#define USIR0_IR7	(1 << 7)	/* Interrup request ep 7 */
+#define USIR0_IR0	(1 << 0)	/* Interrupt request ep 0 */
+#define USIR0_IR1	(1 << 1)	/* Interrupt request ep 1 */
+#define USIR0_IR2	(1 << 2)	/* Interrupt request ep 2 */
+#define USIR0_IR3	(1 << 3)	/* Interrupt request ep 3 */
+#define USIR0_IR4	(1 << 4)	/* Interrupt request ep 4 */
+#define USIR0_IR5	(1 << 5)	/* Interrupt request ep 5 */
+#define USIR0_IR6	(1 << 6)	/* Interrupt request ep 6 */
+#define USIR0_IR7	(1 << 7)	/* Interrupt request ep 7 */
 
 #define USIR1		__REG(0x4060005C)  /* UDC Status Interrupt Register 1 */
 
-#define USIR1_IR8	(1 << 0)	/* Interrup request ep 8 */
-#define USIR1_IR9	(1 << 1)	/* Interrup request ep 9 */
-#define USIR1_IR10	(1 << 2)	/* Interrup request ep 10 */
-#define USIR1_IR11	(1 << 3)	/* Interrup request ep 11 */
-#define USIR1_IR12	(1 << 4)	/* Interrup request ep 12 */
-#define USIR1_IR13	(1 << 5)	/* Interrup request ep 13 */
-#define USIR1_IR14	(1 << 6)	/* Interrup request ep 14 */
-#define USIR1_IR15	(1 << 7)	/* Interrup request ep 15 */
+#define USIR1_IR8	(1 << 0)	/* Interrupt request ep 8 */
+#define USIR1_IR9	(1 << 1)	/* Interrupt request ep 9 */
+#define USIR1_IR10	(1 << 2)	/* Interrupt request ep 10 */
+#define USIR1_IR11	(1 << 3)	/* Interrupt request ep 11 */
+#define USIR1_IR12	(1 << 4)	/* Interrupt request ep 12 */
+#define USIR1_IR13	(1 << 5)	/* Interrupt request ep 13 */
+#define USIR1_IR14	(1 << 6)	/* Interrupt request ep 14 */
+#define USIR1_IR15	(1 << 7)	/* Interrupt request ep 15 */
 
 #elif defined(CONFIG_PXA27x)
 
@@ -1020,7 +1020,7 @@
 #define ICSR0		__REG(0x40800014)  /* ICP Status Register 0 */
 #define ICSR1		__REG(0x40800018)  /* ICP Status Register 1 */
 
-#define ICCR0_AME	(1 << 7)	/* Adress match enable */
+#define ICCR0_AME	(1 << 7)	/* Address match enable */
 #define ICCR0_TIE	(1 << 6)	/* Transmit FIFO interrupt enable */
 #define ICCR0_RIE	(1 << 5)	/* Recieve FIFO interrupt enable */
 #define ICCR0_RXE	(1 << 4)	/* Receive enable */
@@ -1668,7 +1668,7 @@
 #define SSCR1_TSRE		(1 << 21)	/* Transmit Service Request Enable */
 #define SSCR1_RSRE		(1 << 20)	/* Receive Service Request Enable */
 #define SSCR1_TINTE		(1 << 19)	/* Receiver Time-out Interrupt enable */
-#define SSCR1_PINTE		(1 << 18)	/* Peripheral Trailing Byte Interupt Enable */
+#define SSCR1_PINTE		(1 << 18)	/* Peripheral Trailing Byte Interrupt Enable */
 #define SSCR1_STRF		(1 << 15)	/* Select FIFO or EFWR */
 #define SSCR1_EFWR		(1 << 14)	/* Enable FIFO Write/Read */
 
diff --git a/include/asm-arm/hardware/it8152.h b/include/asm-arm/hardware/it8152.h
index aaebb61..74b5fff 100644
--- a/include/asm-arm/hardware/it8152.h
+++ b/include/asm-arm/hardware/it8152.h
@@ -42,7 +42,7 @@ extern unsigned long it8152_base_address;
 #define IT8152_GPIO_GPDR		__REG_IT8152(0x3f00500)
 
 /*
-  Interrup contoler per register summary:
+  Interrupt controller per register summary:
   ---------------------------------------
   LCDNIRR:
   IT8152_LD_IRQ(8) PCICLK stop
diff --git a/include/asm-arm/mach/udc_pxa2xx.h b/include/asm-arm/mach/udc_pxa2xx.h
index ff0a957..dd4b369 100644
--- a/include/asm-arm/mach/udc_pxa2xx.h
+++ b/include/asm-arm/mach/udc_pxa2xx.h
@@ -16,7 +16,7 @@ struct pxa2xx_udc_mach_info {
 #define	PXA2XX_UDC_CMD_DISCONNECT	1	/* so host won't see us */
 
 	/* Boards following the design guidelines in the developer's manual,
-	 * with on-chip GPIOs not Lubbock's wierd hardware, can have a sane
+	 * with on-chip GPIOs not Lubbock's weird hardware, can have a sane
 	 * VBUS IRQ and omit the methods above.  Store the GPIO number
 	 * here; for GPIO 0, also mask in one of the pxa_gpio_mode() bits.
 	 */
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] arch/blackfin/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
  2007-12-17 19:30 ` [PATCH] arch/arm/: " Joe Perches
  2007-12-17 19:30 ` [PATCH] include/asm-arm/: " Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-17 19:49   ` [Uclinux-dist-devel] " Mike Frysinger
  2007-12-17 19:30 ` [PATCH] arch/h8300/: " Joe Perches
                   ` (5 subsequent siblings)
  8 siblings, 1 reply; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Blackfin Architecture Team


Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/blackfin/kernel/early_printk.c      |    2 +-
 arch/blackfin/mach-bf548/ints-priority.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/kernel/early_printk.c b/arch/blackfin/kernel/early_printk.c
index 724f4a5..fb11ce6 100644
--- a/arch/blackfin/kernel/early_printk.c
+++ b/arch/blackfin/kernel/early_printk.c
@@ -187,7 +187,7 @@ asmlinkage void __init init_early_exception_vectors(void)
 	bfin_write_EVT15(early_trap);
 	CSYNC();
 
-	/* Set all the return from interupt, exception, NMI to a known place
+	/* Set all the return from interrupt, exception, NMI to a known place
 	 * so if we do a RETI, RETX or RETN by mistake - we go somewhere known
 	 * Note - don't change RETS - we are in a subroutine, or
 	 * RETE - since it might screw up if emulator is attached
diff --git a/arch/blackfin/mach-bf548/ints-priority.c b/arch/blackfin/mach-bf548/ints-priority.c
index cb0ebac..546517c 100644
--- a/arch/blackfin/mach-bf548/ints-priority.c
+++ b/arch/blackfin/mach-bf548/ints-priority.c
@@ -4,7 +4,7 @@
  * Author:       Michael Hennerich
  *
  * Created:
- * Description:  Set up the interupt priorities
+ * Description:  Set up the interrupt priorities
  *
  * Modified:
  *               Copyright 2004-2006 Analog Devices Inc.
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] arch/h8300/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
                   ` (2 preceding siblings ...)
  2007-12-17 19:30 ` [PATCH] arch/blackfin/: " Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-17 19:30 ` [PATCH] arch/ia64/: " Joe Perches
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton


Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/h8300/platform/h8s/ints.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/h8300/platform/h8s/ints.c b/arch/h8300/platform/h8s/ints.c
index 551fd5f..ac10b97 100644
--- a/arch/h8300/platform/h8s/ints.c
+++ b/arch/h8300/platform/h8s/ints.c
@@ -121,7 +121,7 @@ void __init init_IRQ(void)
 		printk("virtual vector at 0x%08lx\n",(unsigned long)ramvec);
 
 #if defined(CONFIG_GDB_DEBUG)
-	/* save orignal break vector */
+	/* save original break vector */
 	break_vec = ramvec[TRAP3_VEC];
 #else
 	break_vec = VECTOR(trace_break);
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] arch/ia64/: Spelling fixes
@ 2007-12-17 19:30 Joe Perches
  2007-12-17 19:30 ` [PATCH] arch/arm/: " Joe Perches
                   ` (8 more replies)
  0 siblings, 9 replies; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Lennert Buytenhek, Richard Purdie


Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/ia64/sn/pci/tioce_provider.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
index cee9379..e1a3e19 100644
--- a/arch/ia64/sn/pci/tioce_provider.c
+++ b/arch/ia64/sn/pci/tioce_provider.c
@@ -41,7 +41,7 @@
  *	} else
  *		do desired mmr access
  *
- * According to hw, we can use reads instead of writes to the above addres
+ * According to hw, we can use reads instead of writes to the above address
  *
  * Note this WAR can only to be used for accessing internal MMR's in the
  * TIOCE Coretalk Address Range 0x0 - 0x07ff_ffff.  This includes the
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] arch/ia64/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
                   ` (3 preceding siblings ...)
  2007-12-17 19:30 ` [PATCH] arch/h8300/: " Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-18  7:49     ` Jes Sorensen
  2007-12-17 19:30 ` [PATCH] include/asm-ia64/: " Joe Perches
                   ` (3 subsequent siblings)
  8 siblings, 1 reply; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel
  Cc: Andrew Morton, Jes Sorensen, Tony Luck, linux-altix, linux-ia64


Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/ia64/sn/pci/tioce_provider.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
index cee9379..e1a3e19 100644
--- a/arch/ia64/sn/pci/tioce_provider.c
+++ b/arch/ia64/sn/pci/tioce_provider.c
@@ -41,7 +41,7 @@
  *	} else
  *		do desired mmr access
  *
- * According to hw, we can use reads instead of writes to the above addres
+ * According to hw, we can use reads instead of writes to the above address
  *
  * Note this WAR can only to be used for accessing internal MMR's in the
  * TIOCE Coretalk Address Range 0x0 - 0x07ff_ffff.  This includes the
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] include/asm-ia64/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
                   ` (4 preceding siblings ...)
  2007-12-17 19:30 ` [PATCH] arch/ia64/: " Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-17 19:30 ` [PATCH] arch/m32r/: " Joe Perches
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Tony Luck, linux-ia64


Signed-off-by: Joe Perches <joe@perches.com>
---
 include/asm-ia64/hw_irq.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-ia64/hw_irq.h b/include/asm-ia64/hw_irq.h
index bba5baa..7e6e377 100644
--- a/include/asm-ia64/hw_irq.h
+++ b/include/asm-ia64/hw_irq.h
@@ -63,7 +63,7 @@ extern int ia64_last_device_vector;
 #define IA64_NUM_DEVICE_VECTORS		(IA64_LAST_DEVICE_VECTOR - IA64_FIRST_DEVICE_VECTOR + 1)
 
 #define IA64_MCA_RENDEZ_VECTOR		0xe8	/* MCA rendez interrupt */
-#define IA64_PERFMON_VECTOR		0xee	/* performanc monitor interrupt vector */
+#define IA64_PERFMON_VECTOR		0xee	/* performance monitor interrupt vector */
 #define IA64_TIMER_VECTOR		0xef	/* use highest-prio group 15 interrupt for timer */
 #define	IA64_MCA_WAKEUP_VECTOR		0xf0	/* MCA wakeup (must be >MCA_RENDEZ_VECTOR) */
 #define IA64_IPI_LOCAL_TLB_FLUSH	0xfc	/* SMP flush local TLB */
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] arch/m32r/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
                   ` (5 preceding siblings ...)
  2007-12-17 19:30 ` [PATCH] include/asm-ia64/: " Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-17 19:30 ` [PATCH] arch/mips/: " Joe Perches
  2007-12-17 19:56 ` [PATCH] include/asm-arm/: " J. Bruce Fields
  8 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Hirokazu Takata, in Japanese, linux-m32r


Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/m32r/kernel/ptrace.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/m32r/kernel/ptrace.c b/arch/m32r/kernel/ptrace.c
index ed4d075..9aa615d 100644
--- a/arch/m32r/kernel/ptrace.c
+++ b/arch/m32r/kernel/ptrace.c
@@ -476,7 +476,7 @@ unregister_debug_trap(struct task_struct *child, unsigned long addr,
 		return 0;
 	}
 
-	/* Recover orignal instruction code. */
+	/* Recover original instruction code. */
 	*code = p->insn[i];
 
 	/* Shift debug trap entries. */
-- 
1.5.3.7.949.g2221a6


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* [PATCH] arch/mips/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
                   ` (6 preceding siblings ...)
  2007-12-17 19:30 ` [PATCH] arch/m32r/: " Joe Perches
@ 2007-12-17 19:30 ` Joe Perches
  2007-12-17 19:56 ` [PATCH] include/asm-arm/: " J. Bruce Fields
  8 siblings, 0 replies; 22+ messages in thread
From: Joe Perches @ 2007-12-17 19:30 UTC (permalink / raw)
  To: linux-kernel; +Cc: Andrew Morton, Ralf Baechle, linux-mips


Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/mips/au1000/mtx-1/board_setup.c |    2 +-
 arch/mips/kernel/binfmt_elfn32.c     |    2 +-
 arch/mips/kernel/binfmt_elfo32.c     |    2 +-
 arch/mips/kernel/kspd.c              |    2 +-
 arch/mips/kernel/setup.c             |    4 ++--
 arch/mips/kernel/smtc.c              |    6 +++---
 arch/mips/mm/c-r4k.c                 |    2 +-
 arch/mips/sgi-ip27/ip27-hubio.c      |    2 +-
 8 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/mips/au1000/mtx-1/board_setup.c b/arch/mips/au1000/mtx-1/board_setup.c
index abfc4bc..310d5df 100644
--- a/arch/mips/au1000/mtx-1/board_setup.c
+++ b/arch/mips/au1000/mtx-1/board_setup.c
@@ -99,7 +99,7 @@ mtx1_pci_idsel(unsigned int devsel, int assert)
 #endif
 
        if (assert && devsel != 0) {
-               // supress signal to cardbus
+               // suppress signal to cardbus
                au_writel( 0x00000002, SYS_OUTPUTCLR ); // set EXT_IO3 OFF
        }
        else {
diff --git a/arch/mips/kernel/binfmt_elfn32.c b/arch/mips/kernel/binfmt_elfn32.c
index 9b34238..77db347 100644
--- a/arch/mips/kernel/binfmt_elfn32.c
+++ b/arch/mips/kernel/binfmt_elfn32.c
@@ -98,7 +98,7 @@ static __inline__ void
 jiffies_to_compat_timeval(unsigned long jiffies, struct compat_timeval *value)
 {
 	/*
-	 * Convert jiffies to nanoseconds and seperate with
+	 * Convert jiffies to nanoseconds and separate with
 	 * one divide.
 	 */
 	u64 nsec = (u64)jiffies * TICK_NSEC;
diff --git a/arch/mips/kernel/binfmt_elfo32.c b/arch/mips/kernel/binfmt_elfo32.c
index da41eac..08f4cd7 100644
--- a/arch/mips/kernel/binfmt_elfo32.c
+++ b/arch/mips/kernel/binfmt_elfo32.c
@@ -100,7 +100,7 @@ static inline void
 jiffies_to_compat_timeval(unsigned long jiffies, struct compat_timeval *value)
 {
 	/*
-	 * Convert jiffies to nanoseconds and seperate with
+	 * Convert jiffies to nanoseconds and separate with
 	 * one divide.
 	 */
 	u64 nsec = (u64)jiffies * TICK_NSEC;
diff --git a/arch/mips/kernel/kspd.c b/arch/mips/kernel/kspd.c
index d2c2e00..1630784 100644
--- a/arch/mips/kernel/kspd.c
+++ b/arch/mips/kernel/kspd.c
@@ -222,7 +222,7 @@ void sp_work_handle_request(void)
 		}
 	}
 
-	/* Run the syscall at the priviledge of the user who loaded the
+	/* Run the syscall at the privilege of the user who loaded the
 	   SP program */
 
 	if (vpe_getuid(tclimit))
diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 7f6ddcb..ddc2d6d 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -423,13 +423,13 @@ static void __init bootmem_init(void)
 #endif	/* CONFIG_SGI_IP27 */
 
 /*
- * arch_mem_init - initialize memory managment subsystem
+ * arch_mem_init - initialize memory management subsystem
  *
  *  o plat_mem_setup() detects the memory configuration and will record detected
  *    memory areas using add_memory_region.
  *
  * At this stage the memory configuration of the system is known to the
- * kernel but generic memory managment system is still entirely uninitialized.
+ * kernel but generic memory management system is still entirely uninitialized.
  *
  *  o bootmem_init()
  *  o sparse_init()
diff --git a/arch/mips/kernel/smtc.c b/arch/mips/kernel/smtc.c
index 9c92d42..37ee189 100644
--- a/arch/mips/kernel/smtc.c
+++ b/arch/mips/kernel/smtc.c
@@ -66,7 +66,7 @@ asiduse smtc_live_asid[MAX_SMTC_TLBS][MAX_SMTC_ASIDS];
 static atomic_t ipi_timer_latch[NR_CPUS];
 
 /*
- * Number of InterProcessor Interupt (IPI) message buffers to allocate
+ * Number of InterProcessor Interrupt (IPI) message buffers to allocate
  */
 
 #define IPIBUF_PER_CPU 4
@@ -781,7 +781,7 @@ void smtc_send_ipi(int cpu, int type, unsigned int action)
 	if (cpu_data[cpu].vpe_id != cpu_data[smp_processor_id()].vpe_id) {
 		if (type == SMTC_CLOCK_TICK)
 			atomic_inc(&ipi_timer_latch[cpu]);
-		/* If not on same VPE, enqueue and send cross-VPE interupt */
+		/* If not on same VPE, enqueue and send cross-VPE interrupt */
 		smtc_ipi_nq(&IPIQ[cpu], pipi);
 		LOCK_CORE_PRA();
 		settc(cpu_data[cpu].tc_id);
@@ -1064,7 +1064,7 @@ static void setup_cross_vpe_interrupts(unsigned int nvpe)
 		return;
 
 	if (!cpu_has_vint)
-		panic("SMTC Kernel requires Vectored Interupt support");
+		panic("SMTC Kernel requires Vectored Interrupt support");
 
 	set_vi_handler(MIPS_CPU_IPI_IRQ, ipi_irq_dispatch);
 
diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
index 9355f1c..049ba7f 100644
--- a/arch/mips/mm/c-r4k.c
+++ b/arch/mips/mm/c-r4k.c
@@ -1108,7 +1108,7 @@ static void __init setup_scache(void)
 	/*
 	 * Do the probing thing on R4000SC and R4400SC processors.  Other
 	 * processors don't have a S-cache that would be relevant to the
-	 * Linux memory managment.
+	 * Linux memory management.
 	 */
 	switch (c->cputype) {
 	case CPU_R4000SC:
diff --git a/arch/mips/sgi-ip27/ip27-hubio.c b/arch/mips/sgi-ip27/ip27-hubio.c
index 524b371..a1fa4ab 100644
--- a/arch/mips/sgi-ip27/ip27-hubio.c
+++ b/arch/mips/sgi-ip27/ip27-hubio.c
@@ -168,7 +168,7 @@ static void hub_set_piomode(nasid_t nasid)
 }
 
 /*
- * hub_pio_init  -  PIO-related hub initalization
+ * hub_pio_init  -  PIO-related hub initialization
  *
  * @hub:	hubinfo structure for our hub
  */
-- 
1.5.3.7.949.g2221a6

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [Uclinux-dist-devel] [PATCH] arch/blackfin/: Spelling fixes
  2007-12-17 19:30 ` [PATCH] arch/blackfin/: " Joe Perches
@ 2007-12-17 19:49   ` Mike Frysinger
  0 siblings, 0 replies; 22+ messages in thread
From: Mike Frysinger @ 2007-12-17 19:49 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel, Blackfin Architecture Team, Andrew Morton

On Dec 17, 2007 2:30 PM, Joe Perches <joe@perches.com> wrote:
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/blackfin/kernel/early_printk.c      |    2 +-
>  arch/blackfin/mach-bf548/ints-priority.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

thanks, this has been merged into the Blackfin tree and will get
pushed by Bryan during the next set
-mike

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
                   ` (7 preceding siblings ...)
  2007-12-17 19:30 ` [PATCH] arch/mips/: " Joe Perches
@ 2007-12-17 19:56 ` J. Bruce Fields
       [not found]   ` <1197921847.27386.16.camel@localhost>
  8 siblings, 1 reply; 22+ messages in thread
From: J. Bruce Fields @ 2007-12-17 19:56 UTC (permalink / raw)
  To: Joe Perches
  Cc: linux-kernel, Andrew Morton, Dirk Opfer, Lennert Buytenhek,
	Richard Purdie

My mail client seems to be flagging all your messages as duplicates of each
other.

Hm.  It may be that your headers have two Message-Id's...

Message-Id: <1197919875-5288-3-git-send-email-joe@perches.com>
X-Mailer: git-send-email 1.5.3.7.949.g2221a6
Message-Id:
        <5703e57f925f31fc0eb38873bd7f10fc44f99cb4.1197918889.git.joe@perches.com
        >

... the second of which is pretty weird (and is the same for every message.  Is
that a git-send-email bug or something else?

--b.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
       [not found]   ` <1197921847.27386.16.camel@localhost>
@ 2007-12-17 20:12     ` J. Bruce Fields
  2007-12-17 20:22       ` Joe Perches
  0 siblings, 1 reply; 22+ messages in thread
From: J. Bruce Fields @ 2007-12-17 20:12 UTC (permalink / raw)
  To: Joe Perches; +Cc: git

Hope you don't mind my cc'ing the git list:

On Mon, Dec 17, 2007 at 12:04:07PM -0800, Joe Perches wrote:
> On Mon, 2007-12-17 at 14:56 -0500, J. Bruce Fields wrote:
> > My mail client seems to be flagging all your messages as duplicates of each
> > other.
> > 
> > Hm.  It may be that your headers have two Message-Id's...
> > Message-Id: <1197919875-5288-3-git-send-email-joe@perches.com>
> > X-Mailer: git-send-email 1.5.3.7.949.g2221a6
> > Message-Id:
> >         <5703e57f925f31fc0eb38873bd7f10fc44f99cb4.1197918889.git.joe@perches.com
> >         >
> > 
> > ... the second of which is pretty weird (and is the same for every message.  Is
> > that a git-send-email bug or something else?
> 
> Dunno.  I did a git-format-patch, then git-send-email.

Weird.  Anyone know how that could happen?

--b.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 20:12     ` J. Bruce Fields
@ 2007-12-17 20:22       ` Joe Perches
  2007-12-17 20:51         ` Jeff King
  0 siblings, 1 reply; 22+ messages in thread
From: Joe Perches @ 2007-12-17 20:22 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: git

On Mon, 2007-12-17 at 15:12 -0500, J. Bruce Fields wrote:
> Hope you don't mind my cc'ing the git list:

Nope.  Not a bit.

I had patches that were committed in word order that
I wanted to aggregate by subsystem.

I took all the patches, created a branch, committed
all the patches at once, then used these commands:
 
(patch_order is a directory list)

$ let count=0 ; for line in $(cat patch_order) ; do ((count++)); \
	printf -v tmp "%04u-Spelling-%s" $count $line ; \
	tmp=${tmp//\//-} ; tmp=${tmp// /}; \
	git-format-patch -N --thread --start-number $count -s \
	-o patch3 \
	--subject-prefix="[PATCH] Spelling: $line" master $line  ; done
[converted the subjects appropriately]
$ git-send-email --smtp-server <foo> --smtp-user <bar> \
	--from "Joe Perches <joe@perches.com>" \
	--to "linux-kernel@vger.kernel.org" \
	--cc "Andrew Morton <akpm@linux-foundation.org>" \
	--cc-cmd "../get_maintainer.pl --nogit" \
	--no-thread --suppress-from patch3

I probably just reversed the "--thread" on
git-format-patch and send-email.

cheers, Joe

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 20:22       ` Joe Perches
@ 2007-12-17 20:51         ` Jeff King
  2007-12-17 21:27           ` Junio C Hamano
  0 siblings, 1 reply; 22+ messages in thread
From: Jeff King @ 2007-12-17 20:51 UTC (permalink / raw)
  To: Joe Perches; +Cc: Junio C Hamano, J. Bruce Fields, git

On Mon, Dec 17, 2007 at 12:22:51PM -0800, Joe Perches wrote:

> $ let count=0 ; for line in $(cat patch_order) ; do ((count++)); \
> 	printf -v tmp "%04u-Spelling-%s" $count $line ; \
> 	tmp=${tmp//\//-} ; tmp=${tmp// /}; \
> 	git-format-patch -N --thread --start-number $count -s \
> 	-o patch3 \
> 	--subject-prefix="[PATCH] Spelling: $line" master $line  ; done
> [converted the subjects appropriately]
> $ git-send-email --smtp-server <foo> --smtp-user <bar> \
> 	--from "Joe Perches <joe@perches.com>" \
> 	--to "linux-kernel@vger.kernel.org" \
> 	--cc "Andrew Morton <akpm@linux-foundation.org>" \
> 	--cc-cmd "../get_maintainer.pl --nogit" \
> 	--no-thread --suppress-from patch3

Ah. The problem is that git-send-email unconditionally adds a
message-id. Usually git-format-patch doesn't add one, but for obvious
reasons, it must when doing --thread. Here is a fix.

-- >8 --
git-send-email: avoid duplicate message-ids

We used to unconditionally add a message-id to the outgoing
email without bothering to check if it already had one.
Instead, let's use the existing one.

Signed-off-by: Jeff King <peff@peff.net>
---
It will also happily add duplicate --in-reply-to and --references
headers, but those can be suppressed with --no-thread. Arguably, it
should detect this case and turn on --no-thread, but looking at
git-send-email makes me want to claw my eyes out.

 git-send-email.perl |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 1d6f466..083466a 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -580,7 +580,7 @@ sub send_message
 		$ccline = "\nCc: $cc";
 	}
 	my $sanitized_sender = sanitize_address($sender);
-	make_message_id();
+	make_message_id() unless defined($message_id);
 
 	my $header = "From: $sanitized_sender
 To: $to${ccline}
@@ -718,6 +718,9 @@ foreach my $t (@files) {
 					}
 					push @xh, $_;
 				}
+				elsif (/^Message-Id: (.*)/i) {
+					$message_id = $1;
+				}
 				elsif (!/^Date:\s/ && /^[-A-Za-z]+:\s+\S/) {
 					push @xh, $_;
 				}
-- 
1.5.4.rc0.1146.gc97f-dirty

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 20:51         ` Jeff King
@ 2007-12-17 21:27           ` Junio C Hamano
  2007-12-17 23:05             ` Jeff King
                               ` (2 more replies)
  0 siblings, 3 replies; 22+ messages in thread
From: Junio C Hamano @ 2007-12-17 21:27 UTC (permalink / raw)
  To: Jeff King; +Cc: Joe Perches, J. Bruce Fields, git

Jeff King <peff@peff.net> writes:

> Ah. The problem is that git-send-email unconditionally adds a
> message-id. Usually git-format-patch doesn't add one, but for obvious
> reasons, it must when doing --thread. Here is a fix.

> diff --git a/git-send-email.perl b/git-send-email.perl
> index 1d6f466..083466a 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -580,7 +580,7 @@ sub send_message
>  		$ccline = "\nCc: $cc";
>  	}
>  	my $sanitized_sender = sanitize_address($sender);
> -	make_message_id();
> +	make_message_id() unless defined($message_id);

Isn't this called inside a loop?  If the outgoing message does not
originally have "Message-Id:", does the loop correctly reinitialize
$message_id to undef, or does this change make everybody reuse the same
$message_id over and over again?

I have a feeling that --thread to format-patch is a misfeature.  Why is
it needed if you are feeding the output to send-email?

I wonder if stripping existing "Message-Id:" away just like we strip
away "Date:" from @xh would be a much saner fix.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 21:27           ` Junio C Hamano
@ 2007-12-17 23:05             ` Jeff King
  2007-12-17 23:12               ` Jeff King
  2007-12-17 23:28               ` Junio C Hamano
  2008-01-08 11:15             ` Josh Triplett
  2008-01-08 11:16             ` Josh Triplett
  2 siblings, 2 replies; 22+ messages in thread
From: Jeff King @ 2007-12-17 23:05 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Joe Perches, J. Bruce Fields, git

On Mon, Dec 17, 2007 at 01:27:20PM -0800, Junio C Hamano wrote:

> >  	my $sanitized_sender = sanitize_address($sender);
> > -	make_message_id();
> > +	make_message_id() unless defined($message_id);
> 
> Isn't this called inside a loop?  If the outgoing message does not
> originally have "Message-Id:", does the loop correctly reinitialize
> $message_id to undef, or does this change make everybody reuse the same
> $message_id over and over again?

Yes, sorry. I realized it right after I sent the other out, but then a
repairman showed up to fix my non-working furnace. :)

The following needs to be squashed in (alternatively, the message_id
doesn't need to be a loop variable, so it could be cleaned up. But part
of me says that git-send-email is beyond hope for being clean).

diff --git a/git-send-email.perl b/git-send-email.perl
index 083466a..248d035 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -808,6 +808,7 @@ foreach my $t (@files) {
 			$references = "$message_id";
 		}
 	}
+	$message_id = undef;
 }
 
 if ($compose) {

> I have a feeling that --thread to format-patch is a misfeature.  Why is
> it needed if you are feeding the output to send-email?

I think it is a case of --thread being added for people not using
send-email, and then getting it misused. I am just trying to add a
sanity check to send-email in case the user does something silly (though
one could certainly argue that it is already hopelessly tied to
git-format-patch, and fixing git-format-patch is the right way to go).

> I wonder if stripping existing "Message-Id:" away just like we strip
> away "Date:" from @xh would be a much saner fix.

That is definitely wrong if we expect to re-use the in-reply-to and
references headers that already exist (though obviously we could strip
out all three of those headers and re-add our own).

I don't have a strong opinion. I never use git-send-email myself, but
was just trying to fix a reported bug.

-Peff

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 23:05             ` Jeff King
@ 2007-12-17 23:12               ` Jeff King
  2007-12-17 23:28               ` Junio C Hamano
  1 sibling, 0 replies; 22+ messages in thread
From: Jeff King @ 2007-12-17 23:12 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Joe Perches, J. Bruce Fields, git

On Mon, Dec 17, 2007 at 06:05:58PM -0500, Jeff King wrote:

> > I wonder if stripping existing "Message-Id:" away just like we strip
> > away "Date:" from @xh would be a much saner fix.
> 
> That is definitely wrong if we expect to re-use the in-reply-to and
> references headers that already exist (though obviously we could strip
> out all three of those headers and re-add our own).
> 
> I don't have a strong opinion. I never use git-send-email myself, but
> was just trying to fix a reported bug.

Actually, I don't think stripping the message-id is ever the right
thing. The user put it in there for some purpose, and "ours not to
reason why" (ours but to do and die). IOW, it is not possible for us to
know what we are breaking by changing the message-id. It could simply be
the reply-to header in the following messages, or it could be the
reply-to in some message we have not and will not ever see.

Even if we assume git-send-email only ever gets the unmunged output of
git-format-patch, we do not necessarily know it has been fed all of the
patches during a single run.

-Peff

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 23:05             ` Jeff King
  2007-12-17 23:12               ` Jeff King
@ 2007-12-17 23:28               ` Junio C Hamano
  1 sibling, 0 replies; 22+ messages in thread
From: Junio C Hamano @ 2007-12-17 23:28 UTC (permalink / raw)
  To: Jeff King; +Cc: Joe Perches, J. Bruce Fields, git

Jeff King <peff@peff.net> writes:

>> I wonder if stripping existing "Message-Id:" away just like we strip
>> away "Date:" from @xh would be a much saner fix.
>
> That is definitely wrong if we expect to re-use the in-reply-to and
> references headers that already exist (though obviously we could strip
> out all three of those headers and re-add our own).

Ah, you are right.

And undef $message_id you squashed in definitely belongs there --
"prepare for the next round" section.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] arch/ia64/: Spelling fixes
  2007-12-17 19:30 ` [PATCH] arch/ia64/: " Joe Perches
@ 2007-12-18  7:49     ` Jes Sorensen
  0 siblings, 0 replies; 22+ messages in thread
From: Jes Sorensen @ 2007-12-18  7:49 UTC (permalink / raw)
  To: Joe Perches
  Cc: linux-kernel, Andrew Morton, Tony Luck, linux-altix, linux-ia64

Joe,

I'm curious, do you have a patch that actually fixes something and adds
value to the code? Maybe you could include the spelling fix with that to
improve the S/N ratio?

In addition, posting a patch with no commit comment is no good, please
read through Documentation/SubmittingPatches before posting an update
to this.

Thanks,
Jes


Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/ia64/sn/pci/tioce_provider.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> index cee9379..e1a3e19 100644
> --- a/arch/ia64/sn/pci/tioce_provider.c
> +++ b/arch/ia64/sn/pci/tioce_provider.c
> @@ -41,7 +41,7 @@
>   *	} else
>   *		do desired mmr access
>   *
> - * According to hw, we can use reads instead of writes to the above addres
> + * According to hw, we can use reads instead of writes to the above address
>   *
>   * Note this WAR can only to be used for accessing internal MMR's in the
>   * TIOCE Coretalk Address Range 0x0 - 0x07ff_ffff.  This includes the


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] arch/ia64/: Spelling fixes
@ 2007-12-18  7:49     ` Jes Sorensen
  0 siblings, 0 replies; 22+ messages in thread
From: Jes Sorensen @ 2007-12-18  7:49 UTC (permalink / raw)
  To: Joe Perches
  Cc: linux-kernel, Andrew Morton, Tony Luck, linux-altix, linux-ia64

Joe,

I'm curious, do you have a patch that actually fixes something and adds
value to the code? Maybe you could include the spelling fix with that to
improve the S/N ratio?

In addition, posting a patch with no commit comment is no good, please
read through Documentation/SubmittingPatches before posting an update
to this.

Thanks,
Jes


Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  arch/ia64/sn/pci/tioce_provider.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> index cee9379..e1a3e19 100644
> --- a/arch/ia64/sn/pci/tioce_provider.c
> +++ b/arch/ia64/sn/pci/tioce_provider.c
> @@ -41,7 +41,7 @@
>   *	} else
>   *		do desired mmr access
>   *
> - * According to hw, we can use reads instead of writes to the above addres
> + * According to hw, we can use reads instead of writes to the above address
>   *
>   * Note this WAR can only to be used for accessing internal MMR's in the
>   * TIOCE Coretalk Address Range 0x0 - 0x07ff_ffff.  This includes the


^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 21:27           ` Junio C Hamano
  2007-12-17 23:05             ` Jeff King
@ 2008-01-08 11:15             ` Josh Triplett
  2008-01-08 11:16             ` Josh Triplett
  2 siblings, 0 replies; 22+ messages in thread
From: Josh Triplett @ 2008-01-08 11:15 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Jeff King, Joe Perches, J. Bruce Fields, git

Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>> Ah. The problem is that git-send-email unconditionally adds a
>> message-id. Usually git-format-patch doesn't add one, but for obvious
>> reasons, it must when doing --thread. Here is a fix.
> 
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index 1d6f466..083466a 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -580,7 +580,7 @@ sub send_message
>>  		$ccline = "\nCc: $cc";
>>  	}
>>  	my $sanitized_sender = sanitize_address($sender);
>> -	make_message_id();
>> +	make_message_id() unless defined($message_id);
> 
> Isn't this called inside a loop?  If the outgoing message does not
> originally have "Message-Id:", does the loop correctly reinitialize
> $message_id to undef, or does this change make everybody reuse the same
> $message_id over and over again?
> 
> I have a feeling that --thread to format-patch is a misfeature.  Why is
> it needed if you are feeding the output to send-email?

I added that option; see (d1566f7883f727f38bf442af3fdb69d36e6fcea2,
cc35de8470541e389b7d2bdda4c901574720fa81, and
da56645dd7c1175fc2ed1628ac35fdd35e705641).  I use git-imap-send, not
git-send-email, and I wanted to thread my patches.

- Josh Triplett

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: [PATCH] include/asm-arm/: Spelling fixes
  2007-12-17 21:27           ` Junio C Hamano
  2007-12-17 23:05             ` Jeff King
  2008-01-08 11:15             ` Josh Triplett
@ 2008-01-08 11:16             ` Josh Triplett
  2 siblings, 0 replies; 22+ messages in thread
From: Josh Triplett @ 2008-01-08 11:16 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Jeff King, Joe Perches, J. Bruce Fields, git

Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>> Ah. The problem is that git-send-email unconditionally adds a
>> message-id. Usually git-format-patch doesn't add one, but for obvious
>> reasons, it must when doing --thread. Here is a fix.
> 
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index 1d6f466..083466a 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -580,7 +580,7 @@ sub send_message
>>  		$ccline = "\nCc: $cc";
>>  	}
>>  	my $sanitized_sender = sanitize_address($sender);
>> -	make_message_id();
>> +	make_message_id() unless defined($message_id);
> 
> Isn't this called inside a loop?  If the outgoing message does not
> originally have "Message-Id:", does the loop correctly reinitialize
> $message_id to undef, or does this change make everybody reuse the same
> $message_id over and over again?
> 
> I have a feeling that --thread to format-patch is a misfeature.  Why is
> it needed if you are feeding the output to send-email?

I added that option; see (d1566f7883f727f38bf442af3fdb69d36e6fcea2,
cc35de8470541e389b7d2bdda4c901574720fa81, and
da56645dd7c1175fc2ed1628ac35fdd35e705641).  I use git-imap-send, not
git-send-email, and I wanted to thread my patches.

- Josh Triplett

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2008-01-08 11:24 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-17 19:30 [PATCH] arch/ia64/: Spelling fixes Joe Perches
2007-12-17 19:30 ` [PATCH] arch/arm/: " Joe Perches
2007-12-17 19:30 ` [PATCH] include/asm-arm/: " Joe Perches
2007-12-17 19:30 ` [PATCH] arch/blackfin/: " Joe Perches
2007-12-17 19:49   ` [Uclinux-dist-devel] " Mike Frysinger
2007-12-17 19:30 ` [PATCH] arch/h8300/: " Joe Perches
2007-12-17 19:30 ` [PATCH] arch/ia64/: " Joe Perches
2007-12-18  7:49   ` Jes Sorensen
2007-12-18  7:49     ` Jes Sorensen
2007-12-17 19:30 ` [PATCH] include/asm-ia64/: " Joe Perches
2007-12-17 19:30 ` [PATCH] arch/m32r/: " Joe Perches
2007-12-17 19:30 ` [PATCH] arch/mips/: " Joe Perches
2007-12-17 19:56 ` [PATCH] include/asm-arm/: " J. Bruce Fields
     [not found]   ` <1197921847.27386.16.camel@localhost>
2007-12-17 20:12     ` J. Bruce Fields
2007-12-17 20:22       ` Joe Perches
2007-12-17 20:51         ` Jeff King
2007-12-17 21:27           ` Junio C Hamano
2007-12-17 23:05             ` Jeff King
2007-12-17 23:12               ` Jeff King
2007-12-17 23:28               ` Junio C Hamano
2008-01-08 11:15             ` Josh Triplett
2008-01-08 11:16             ` Josh Triplett

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.