From: Peter Zijlstra <peterz@infradead.org>
To: "Jörn Engel" <joern@logfs.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org, mingo@redhat.com,
linux-mtd@lists.infradead.org, Erez Zadok <ezk@cs.sunysb.edu>,
dwmw2@infradead.org
Subject: Re: [PATCH] block2mtd lockdep_init_map warning
Date: Mon, 07 Jan 2008 11:34:25 +0100 [thread overview]
Message-ID: <1199702065.7143.13.camel@twins> (raw)
In-Reply-To: <20080107102025.GA5338@lazybastard.org>
On Mon, 2008-01-07 at 11:20 +0100, Jörn Engel wrote:
> On Mon, 7 January 2008 11:05:26 +0100, Peter Zijlstra wrote:
> >
> > Would something like this work for people?
>
> Looks a lot better than what I thought of. However, does the #ifdef
> within is_module_address() make sense when afaict lockdep is the only
> caller of that function? Looks as if the whole function should be made
> conditional or none of it.
Ah, I hadn't bothered to check if there were more users. /me does a (not
so quick) git grep and finds lockdep is indeed the only caller. Sure, we
can move the whole function into the ifdef.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: "Jörn Engel" <joern@logfs.org>
Cc: Erez Zadok <ezk@cs.sunysb.edu>,
dwmw2@infradead.org, linux-mtd@lists.infradead.org,
mingo@redhat.com, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] block2mtd lockdep_init_map warning
Date: Mon, 07 Jan 2008 11:34:25 +0100 [thread overview]
Message-ID: <1199702065.7143.13.camel@twins> (raw)
In-Reply-To: <20080107102025.GA5338@lazybastard.org>
On Mon, 2008-01-07 at 11:20 +0100, Jörn Engel wrote:
> On Mon, 7 January 2008 11:05:26 +0100, Peter Zijlstra wrote:
> >
> > Would something like this work for people?
>
> Looks a lot better than what I thought of. However, does the #ifdef
> within is_module_address() make sense when afaict lockdep is the only
> caller of that function? Looks as if the whole function should be made
> conditional or none of it.
Ah, I hadn't bothered to check if there were more users. /me does a (not
so quick) git grep and finds lockdep is indeed the only caller. Sure, we
can move the whole function into the ifdef.
next prev parent reply other threads:[~2008-01-07 10:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 7:17 [PATCH] block2mtd lockdep_init_map warning Erez Zadok
2008-01-06 13:13 ` Jörn Engel
2008-01-06 13:13 ` Jörn Engel
2008-01-06 13:39 ` Peter Zijlstra
2008-01-06 13:39 ` Peter Zijlstra
2008-01-06 19:11 ` Erez Zadok
2008-01-06 19:11 ` Erez Zadok
2008-01-06 21:25 ` Jörn Engel
2008-01-06 21:25 ` Jörn Engel
2008-01-07 10:05 ` Peter Zijlstra
2008-01-07 10:05 ` Peter Zijlstra
2008-01-07 10:20 ` Jörn Engel
2008-01-07 10:20 ` Jörn Engel
2008-01-07 10:34 ` Peter Zijlstra [this message]
2008-01-07 10:34 ` Peter Zijlstra
2008-01-08 0:47 ` Rusty Russell
2008-01-08 0:47 ` Rusty Russell
2008-01-16 8:16 ` Peter Zijlstra
2008-01-16 8:16 ` Peter Zijlstra
2008-01-16 21:20 ` Jörn Engel
2008-01-16 21:20 ` Jörn Engel
2008-01-20 21:01 ` Erez Zadok
2008-01-20 21:01 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199702065.7143.13.camel@twins \
--to=peterz@infradead.org \
--cc=dwmw2@infradead.org \
--cc=ezk@cs.sunysb.edu \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.