All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [kvm-ppc-devel] [kvm-devel] [PATCH] Enhnace kvm-userspace
Date: Tue, 08 Jan 2008 22:13:34 +0000	[thread overview]
Message-ID: <1199830415.12840.1.camel@thinkpad> (raw)
In-Reply-To: <4783F33D.30506-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>

My upstream must be out of date. But the way upstream seems really
awful. If I mistype any valid option then I don't even get an error.
It's passed as a qemu option. This does not seem to be a great idea,
causes more headaches.


On Tue, 2008-01-08 at 16:03 -0600, Anthony Liguori wrote:
> Jerone Young wrote:
> > # HG changeset patch
> > # User Jerone Young <jyoung5@us.ibm.com>
> > # Date 1199829366 21600
> > # Node ID 5d3976c5b77e42ad1f63d02271a7ff2086cabb6c
> > # Parent  bff590d13f32071b50d79f511424821847ed5ba7
> > Enhnace kvm-userspace configure script for powerpc
> >
> >
> > This patch adds more options to compile qemu with and
> > places a conditional for powerpc to compile qemu.
> >
> > Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> >
> > diff --git a/configure b/configure
> > --- a/configure
> > +++ b/configure
> > @@ -8,7 +8,10 @@ qemu_ldflags> >  qemu_ldflags> >  enable_alsa> >  disable_vnc_tls> > +disable_sdl> > +disable_gfx_check> >  disable_gcc_check> > +enable_qemu_static> >  cross_prefix> >  arch=`uname -m`
> >  target_exec> > @@ -28,8 +31,11 @@ usage() {
> >  	    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration
> >  	    --enable-alsa          enable alsa support for qemu
> >  	    --disable-vnc-tls      disable vnc tls support for qemu
> > +	    --disable-sdl          disable sdl support for qemu
> > +	    --disable-gfx-check    disable graphics check for qemu
> >  	    --disable-gcc-check    don't insist on gcc-3.x
> >  	                           CAUTION: this will break running without kvm
> > +	    --qemu-static          compile qemu to be a static executable
> >  EOF
> >      exit 1
> >  }
> > @@ -66,8 +72,17 @@ while [[ "$1" = -* ]]; do
> >  	--disable-vnc-tls)
> >  	    disable_vnc_tls=1
> >  	    ;;
> > +	--disable-sdl)
> > +	    disable_sdl=1
> > +	    ;;
> > +	--disable-gfx-check)
> > +	    disable_gfx_check=1
> > +	    ;;
> >  	--disable-gcc-check)
> >  	    disable_gcc_check=1
> > +	    ;;
> >   
> 
> I believe that unknown options are passed directly to QEMU so I don't 
> think this is strictly necessary.  It should Just Work already.
> 
> Regards,
> 
> Anthony Liguori
> 
> > +	--qemu-static)
> > +	    enable_qemu_static=1
> >  	    ;;
> >  	--arch)
> >  	    arch="$arg"
> > @@ -106,6 +121,10 @@ if [ "$arch" = "ia64" ]; then
> >      target_exec="ia64-softmmu"
> >  fi
> >  
> > +if [ "$arch" = "powerpc" ]; then
> > +    target_exec="ppcemb-softmmu"
> > +fi
> > +
> >  #configure user dir
> >  (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
> >            --arch="$arch" \
> > @@ -120,8 +139,11 @@ fi
> >      ${enable_alsa:+"--enable-alsa"} \
> >      ${disable_vnc_tls:+"--disable-vnc-tls"} \
> >      ${disable_gcc_check:+"--disable-gcc-check"} \
> > +    ${disable_sdl:+"--disable-sdl"} \
> > +    ${disable_gfx_check:+"--disable-gfx-check"} \
> >      --prefix="$prefix" \
> >      ${qemu_cc:+"--cc=$qemu_cc"} \
> > +    ${enable_qemu_static:+"--static"} \
> >      ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
> >      ${cross_prefix:+"--cpu=$arch"}
> >  )
> >
> > -------------------------------------------------------------------------
> > Check out the new SourceForge.net Marketplace.
> > It's the best place to buy or sell services for
> > just about anything Open Source.
> > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> > _______________________________________________
> > kvm-devel mailing list
> > kvm-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/kvm-devel
> >   
> 


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Enhnace kvm-userspace configure script for	powerpc
Date: Tue, 08 Jan 2008 16:13:34 -0600	[thread overview]
Message-ID: <1199830415.12840.1.camel@thinkpad> (raw)
In-Reply-To: <4783F33D.30506-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>

My upstream must be out of date. But the way upstream seems really
awful. If I mistype any valid option then I don't even get an error.
It's passed as a qemu option. This does not seem to be a great idea,
causes more headaches.


On Tue, 2008-01-08 at 16:03 -0600, Anthony Liguori wrote:
> Jerone Young wrote:
> > # HG changeset patch
> > # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > # Date 1199829366 21600
> > # Node ID 5d3976c5b77e42ad1f63d02271a7ff2086cabb6c
> > # Parent  bff590d13f32071b50d79f511424821847ed5ba7
> > Enhnace kvm-userspace configure script for powerpc
> >
> >
> > This patch adds more options to compile qemu with and
> > places a conditional for powerpc to compile qemu.
> >
> > Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> >
> > diff --git a/configure b/configure
> > --- a/configure
> > +++ b/configure
> > @@ -8,7 +8,10 @@ qemu_ldflags=
> >  qemu_ldflags=
> >  enable_alsa=
> >  disable_vnc_tls=
> > +disable_sdl=
> > +disable_gfx_check=
> >  disable_gcc_check=
> > +enable_qemu_static=
> >  cross_prefix=
> >  arch=`uname -m`
> >  target_exec=
> > @@ -28,8 +31,11 @@ usage() {
> >  	    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration
> >  	    --enable-alsa          enable alsa support for qemu
> >  	    --disable-vnc-tls      disable vnc tls support for qemu
> > +	    --disable-sdl          disable sdl support for qemu
> > +	    --disable-gfx-check    disable graphics check for qemu
> >  	    --disable-gcc-check    don't insist on gcc-3.x
> >  	                           CAUTION: this will break running without kvm
> > +	    --qemu-static          compile qemu to be a static executable
> >  EOF
> >      exit 1
> >  }
> > @@ -66,8 +72,17 @@ while [[ "$1" = -* ]]; do
> >  	--disable-vnc-tls)
> >  	    disable_vnc_tls=1
> >  	    ;;
> > +	--disable-sdl)
> > +	    disable_sdl=1
> > +	    ;;
> > +	--disable-gfx-check)
> > +	    disable_gfx_check=1
> > +	    ;;
> >  	--disable-gcc-check)
> >  	    disable_gcc_check=1
> > +	    ;;
> >   
> 
> I believe that unknown options are passed directly to QEMU so I don't 
> think this is strictly necessary.  It should Just Work already.
> 
> Regards,
> 
> Anthony Liguori
> 
> > +	--qemu-static)
> > +	    enable_qemu_static=1
> >  	    ;;
> >  	--arch)
> >  	    arch="$arg"
> > @@ -106,6 +121,10 @@ if [ "$arch" = "ia64" ]; then
> >      target_exec="ia64-softmmu"
> >  fi
> >  
> > +if [ "$arch" = "powerpc" ]; then
> > +    target_exec="ppcemb-softmmu"
> > +fi
> > +
> >  #configure user dir
> >  (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
> >            --arch="$arch" \
> > @@ -120,8 +139,11 @@ fi
> >      ${enable_alsa:+"--enable-alsa"} \
> >      ${disable_vnc_tls:+"--disable-vnc-tls"} \
> >      ${disable_gcc_check:+"--disable-gcc-check"} \
> > +    ${disable_sdl:+"--disable-sdl"} \
> > +    ${disable_gfx_check:+"--disable-gfx-check"} \
> >      --prefix="$prefix" \
> >      ${qemu_cc:+"--cc=$qemu_cc"} \
> > +    ${enable_qemu_static:+"--static"} \
> >      ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
> >      ${cross_prefix:+"--cpu=$arch"}
> >  )
> >
> > -------------------------------------------------------------------------
> > Check out the new SourceForge.net Marketplace.
> > It's the best place to buy or sell services for
> > just about anything Open Source.
> > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
> > _______________________________________________
> > kvm-devel mailing list
> > kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/kvm-devel
> >   
> 


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

  parent reply	other threads:[~2008-01-08 22:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08 22:00 [kvm-ppc-devel] [PATCH] Enhnace kvm-userspace configure script for Jerone Young
2008-01-08 22:00 ` [PATCH] Enhnace kvm-userspace configure script for powerpc Jerone Young
2008-01-08 22:03 ` [kvm-ppc-devel] [kvm-devel] [PATCH] Enhnace kvm-userspace Anthony Liguori
2008-01-08 22:03   ` [PATCH] Enhnace kvm-userspace configure script for powerpc Anthony Liguori
     [not found]   ` <4783F33D.30506-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2008-01-08 22:13     ` Jerone Young [this message]
2008-01-08 22:13       ` Jerone Young
2008-01-08 22:19       ` [kvm-ppc-devel] [kvm-devel] [PATCH] Enhnace kvm-userspace Anthony Liguori
2008-01-08 22:19         ` [PATCH] Enhnace kvm-userspace configure script for powerpc Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1199830415.12840.1.camel@thinkpad \
    --to=jyoung5@us.ibm.com \
    --cc=anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.