From: Joonwoo Park <joonwpark81@gmail.com>
To: Zhu Yi <yi.zhu@intel.com>, netdev@vger.kernel.org
Cc: lkml <linux-kernel@vger.kernel.org>,
ipw3945-devel@lists.sourceforge.net,
linux-wireless@vger.kernel.org,
Joonwoo Park <joonwpark81@gmail.com>
Subject: [PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and tasklet for down iwlwifi
Date: Wed, 9 Jan 2008 20:02:28 +0900 [thread overview]
Message-ID: <11998765481610-git-send-email-joonwpark81@gmail.com> (raw)
After disabling interrupts, it's possible irq & tasklet is pending or running
This patch eleminates races for down iwlwifi
Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index c97448d..3986aaf 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -6262,6 +6262,10 @@ static void __iwl_down(struct iwl_priv *priv)
/* tell the device to stop sending interrupts */
iwl_disable_interrupts(priv);
+ /* synchronize irq and tasklet */
+ synchronize_irq(priv->pci_dev->irq);
+ tasklet_kill(&priv->irq_tasklet);
+
if (priv->mac80211_registered)
ieee80211_stop_queues(priv->hw);
--
1.5.3.rc5
WARNING: multiple messages have this Message-ID (diff)
From: Joonwoo Park <joonwpark81@gmail.com>
To: Zhu Yi <yi.zhu@intel.com>, netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Joonwoo Park <joonwpark81@gmail.com>,
ipw3945-devel@lists.sourceforge.net
Subject: [PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and tasklet for down iwlwifi
Date: Wed, 9 Jan 2008 20:02:28 +0900 [thread overview]
Message-ID: <11998765481610-git-send-email-joonwpark81@gmail.com> (raw)
After disabling interrupts, it's possible irq & tasklet is pending or running
This patch eleminates races for down iwlwifi
Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index c97448d..3986aaf 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -6262,6 +6262,10 @@ static void __iwl_down(struct iwl_priv *priv)
/* tell the device to stop sending interrupts */
iwl_disable_interrupts(priv);
+ /* synchronize irq and tasklet */
+ synchronize_irq(priv->pci_dev->irq);
+ tasklet_kill(&priv->irq_tasklet);
+
if (priv->mac80211_registered)
ieee80211_stop_queues(priv->hw);
--
1.5.3.rc5
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next reply other threads:[~2008-01-09 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 11:02 Joonwoo Park [this message]
2008-01-09 11:02 ` [PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and tasklet for down iwlwifi Joonwoo Park
2008-01-10 19:10 ` [ipw3945-devel] [PATCH 2/5] iwlwifi: iwl3945 synchronize interruptand " Chatre, Reinette
2008-01-10 19:10 ` Chatre, Reinette
2008-01-11 1:24 ` Joonwoo Park
2008-01-11 1:24 ` Joonwoo Park
2008-01-11 1:42 ` [ipw3945-devel] " Chatre, Reinette
2008-01-11 2:38 ` Joonwoo Park
2008-01-14 8:35 ` Joonwoo Park
2008-01-14 8:35 ` Joonwoo Park
2008-01-14 9:42 ` Joonwoo Park
2008-01-15 19:21 ` Chatre, Reinette
2008-01-16 4:15 ` Joonwoo Park
2008-01-16 16:37 ` Chatre, Reinette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11998765481610-git-send-email-joonwpark81@gmail.com \
--to=joonwpark81@gmail.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.