From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] fix endianess in IEEE-1275 integer properties
Date: Mon, 14 Jan 2008 09:20:39 -0500 [thread overview]
Message-ID: <1200320439.13534.4.camel@dv> (raw)
In-Reply-To: <20080113203041.GA25702@thorin>
On Sun, 2008-01-13 at 21:30 +0100, Robert Millan wrote:
> Integer properties are always in big endian. This (incomplete) patch is my
> suggested approach to deal with this. I'd like to receive input about it
> before I complete it (checking all calls to grub_ieee1275_get_property
> through GRUB and replacing with grub_ieee1275_get_integer_property when
> appropiate).
>
> Again, some testing on Apple/IBM/Genesi hardware would be nice.
It doesn't apply cleanly, and I don't see how the result of
grub_ieee1275_get_integer_property() is used. I suggest that you go
ahead with the changes as long as you get them right for your platform.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-01-14 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 20:30 [PATCH] fix endianess in IEEE-1275 integer properties Robert Millan
2008-01-14 14:20 ` Pavel Roskin [this message]
2008-01-14 14:27 ` Robert Millan
2008-01-15 4:49 ` Pavel Roskin
2008-01-15 12:12 ` Robert Millan
2008-01-15 12:22 ` Robert Millan
2008-01-15 14:41 ` Pavel Roskin
2008-01-15 16:13 ` Robert Millan
2008-01-15 12:30 ` Marco Gerards
2008-01-15 12:32 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200320439.13534.4.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.