All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: Commit for mm/page_alloc.c breaks boot process on my machine
Date: Wed, 06 Feb 2008 07:50:20 +1100	[thread overview]
Message-ID: <1202244620.7079.70.camel@pasglop> (raw)
In-Reply-To: <20080205102347.GA11949@csn.ul.ie>


On Tue, 2008-02-05 at 10:23 +0000, Mel Gorman wrote:
> On (05/02/08 11:01), Benjamin Herrenschmidt didst pronounce:
> > 
> > > 
> > > It's a virtual address so it depends on the value of CONFIG_KERNEL_START
> > > as to whether this is a user program address or not.
> > 
> > Shouldn't it be PAGE_OFFSET ? I mean, CONFIG_KERNEL_START should work
> > on powerpc, but still...
> > 
> 
> mel@arnold:~/git/linux-2.6$ grep PAGE_OFFSET include/asm-ppc/page.h
> #define PAGE_OFFSET     CONFIG_KERNEL_START

On powerpc sure.... but it's still dodgy I think.

Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Gerhard Pircher <gerhard_pircher@gmx.net>,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: Commit for mm/page_alloc.c breaks boot process on my machine
Date: Wed, 06 Feb 2008 07:50:20 +1100	[thread overview]
Message-ID: <1202244620.7079.70.camel@pasglop> (raw)
In-Reply-To: <20080205102347.GA11949@csn.ul.ie>


On Tue, 2008-02-05 at 10:23 +0000, Mel Gorman wrote:
> On (05/02/08 11:01), Benjamin Herrenschmidt didst pronounce:
> > 
> > > 
> > > It's a virtual address so it depends on the value of CONFIG_KERNEL_START
> > > as to whether this is a user program address or not.
> > 
> > Shouldn't it be PAGE_OFFSET ? I mean, CONFIG_KERNEL_START should work
> > on powerpc, but still...
> > 
> 
> mel@arnold:~/git/linux-2.6$ grep PAGE_OFFSET include/asm-ppc/page.h
> #define PAGE_OFFSET     CONFIG_KERNEL_START

On powerpc sure.... but it's still dodgy I think.

Ben.



  reply	other threads:[~2008-02-05 20:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 18:42 Commit for mm/page_alloc.c breaks boot process on my machine Gerhard Pircher
2008-02-01 19:11 ` Mel Gorman
2008-02-01 20:05   ` Gerhard Pircher
2008-02-01 20:25     ` Mel Gorman
2008-02-01 21:06       ` Gerhard Pircher
2008-02-04 10:42         ` Mel Gorman
2008-02-04 10:42           ` Mel Gorman
2008-02-04 22:20           ` Gerhard Pircher
2008-02-04 23:30             ` Michael Ellerman
2008-02-05  0:01           ` Benjamin Herrenschmidt
2008-02-05  0:01             ` Benjamin Herrenschmidt
2008-02-05 10:23             ` Mel Gorman
2008-02-05 10:23               ` Mel Gorman
2008-02-05 20:50               ` Benjamin Herrenschmidt [this message]
2008-02-05 20:50                 ` Benjamin Herrenschmidt
2008-02-05  0:07         ` Benjamin Herrenschmidt
2008-02-05  0:06     ` Benjamin Herrenschmidt
2008-02-05 23:17       ` Gerhard Pircher
2008-02-05 23:17         ` Gerhard Pircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202244620.7079.70.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.