From: Joe Perches <joe@perches.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/slub.c - Use print_hex_dump
Date: Fri, 08 Feb 2008 10:24:29 -0800 [thread overview]
Message-ID: <1202495069.27394.85.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0802081006460.28568@schroedinger.engr.sgi.com>
On Fri, 2008-02-08 at 10:07 -0800, Christoph Lameter wrote:
> On Fri, 8 Feb 2008, Joe Perches wrote:
> > Use the library function to dump memory
> Could you please compare the formatting of the output before and
> after? Last time we tried this we had issues because it became a bit ugly.
The difference is the last line of the ascii is not aligned
if the length is non modulo 16.
I have sent a patch to print_hex_dump to always align.
http://lkml.org/lkml/2007/12/6/304
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/slub.c - Use print_hex_dump
Date: Fri, 08 Feb 2008 10:24:29 -0800 [thread overview]
Message-ID: <1202495069.27394.85.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0802081006460.28568@schroedinger.engr.sgi.com>
On Fri, 2008-02-08 at 10:07 -0800, Christoph Lameter wrote:
> On Fri, 8 Feb 2008, Joe Perches wrote:
> > Use the library function to dump memory
> Could you please compare the formatting of the output before and
> after? Last time we tried this we had issues because it became a bit ugly.
The difference is the last line of the ascii is not aligned
if the length is non modulo 16.
I have sent a patch to print_hex_dump to always align.
http://lkml.org/lkml/2007/12/6/304
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-08 18:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 18:03 [PATCH] mm/slub.c - Use print_hex_dump Joe Perches
2008-02-08 18:03 ` Joe Perches
2008-02-08 18:07 ` Christoph Lameter
2008-02-08 18:07 ` Christoph Lameter
2008-02-08 18:24 ` Joe Perches [this message]
2008-02-08 18:24 ` Joe Perches
2008-02-08 18:32 ` Christoph Lameter
2008-02-08 18:32 ` Christoph Lameter
2008-02-08 20:15 ` Joe Perches
2008-02-08 20:15 ` Joe Perches
2008-02-08 20:25 ` Christoph Lameter
2008-02-08 20:25 ` Christoph Lameter
2008-02-08 20:33 ` Joe Perches
2008-02-08 20:33 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202495069.27394.85.camel@localhost \
--to=joe@perches.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.