All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <petkovbb@googlemail.com>
To: bzolnier@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Borislav Petkov <petkovbb@gmail.com>
Subject: [PATCH 0/4] ide: generic packet command representation
Date: Mon, 11 Feb 2008 09:34:36 +0100	[thread overview]
Message-ID: <1202718880-1793-1-git-send-email-petkovbb@gmail.com> (raw)

Hi Bart,

here's the ide_atapi_pc unification series. It all went pretty smoothly along
the search & replace line. Using driver-specific members in ide_atapi_pc like
idefloppy_callback and idetape_callback is kinda dumb but this approach seemed
the fastest versus unnecessary callback function signature change that will
touch stuff all over the place. Besides, ide-tape might be gone soon so that
would alleviate the problem.

On a different note, i noticed ide-scsi might also need a cleanup similar to the
other drivers. It is next on my TODO list in case you don't have anything with a
higher prio.


 drivers/ide/ide-floppy.c |  205 +++++++++++++++++--------------------
 drivers/ide/ide-tape.c   |  251 +++++++++++++++++++++-------------------------
 drivers/scsi/ide-scsi.c  |  133 +++++++++++-------------
 include/linux/ide.h      |   47 +++++++++
 4 files changed, 316 insertions(+), 320 deletions(-)

-- 
Thanks,
Boris.

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <petkovbb@googlemail.com>
To: <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Borislav Petkov <petkovbb@gmail.com>
Subject: [PATCH 0/4] ide: generic packet command representation
Date: Mon, 11 Feb 2008 09:34:36 +0100	[thread overview]
Message-ID: <1202718880-1793-1-git-send-email-petkovbb@gmail.com> (raw)

Hi Bart,

here's the ide_atapi_pc unification series. It all went pretty smoothly along
the search & replace line. Using driver-specific members in ide_atapi_pc like
idefloppy_callback and idetape_callback is kinda dumb but this approach seemed
the fastest versus unnecessary callback function signature change that will
touch stuff all over the place. Besides, ide-tape might be gone soon so that
would alleviate the problem.

On a different note, i noticed ide-scsi might also need a cleanup similar to the
other drivers. It is next on my TODO list in case you don't have anything with a
higher prio.


 drivers/ide/ide-floppy.c |  205 +++++++++++++++++--------------------
 drivers/ide/ide-tape.c   |  251 +++++++++++++++++++++-------------------------
 drivers/scsi/ide-scsi.c  |  133 +++++++++++-------------
 include/linux/ide.h      |   47 +++++++++
 4 files changed, 316 insertions(+), 320 deletions(-)

-- 
Thanks,
Boris.

             reply	other threads:[~2008-02-11  8:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11  8:34 Borislav Petkov [this message]
2008-02-11  8:34 ` [PATCH 0/4] ide: generic packet command representation Borislav Petkov
2008-02-11  8:34 ` [PATCH 1/4] ide: add generic packet command representation ide_atapi_pc Borislav Petkov
2008-02-11  8:34   ` Borislav Petkov
2008-02-11  8:34 ` [PATCH 2/4] ide-floppy: convert driver to using generic ide_atapi_pc Borislav Petkov
2008-02-11  8:34   ` Borislav Petkov
2008-02-11  8:34 ` [PATCH 3/4] ide-tape: " Borislav Petkov
2008-02-11  8:34   ` Borislav Petkov
2008-02-11  8:34 ` [PATCH 4/4] ide-scsi: " Borislav Petkov
2008-02-11  8:34   ` Borislav Petkov
2008-02-12  0:09 ` [PATCH 0/4] ide: generic packet command representation Bartlomiej Zolnierkiewicz
2008-02-12  5:59   ` Borislav Petkov
     [not found]     ` <200802121328.48515.bzolnier@gmail.com>
2008-02-12 15:25       ` [PATCH] ide-scsi: do non-atomic pc->flags testing Borislav Petkov
2008-02-12 20:17         ` Bartlomiej Zolnierkiewicz
2008-02-15 14:04   ` [PATCH 0/4] ide: generic packet command representation Jan Engelhardt
2008-02-15 14:24     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202718880-1793-1-git-send-email-petkovbb@gmail.com \
    --to=petkovbb@googlemail.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.