All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: comments about /etc/default/grub
Date: Tue, 12 Feb 2008 17:55:10 -0500	[thread overview]
Message-ID: <1202856910.20992.30.camel@dv> (raw)
In-Reply-To: <20080212114709.GC19144@thorin>

On Tue, 2008-02-12 at 12:47 +0100, Robert Millan wrote:
> I suppose a distro-agnostic template should really be added, but I
> didn't
> find an ellegant way to solve the GRUB_DISTRIBUTOR "problem".
> 
> For other reasons, I was thinking in a directory (let's call it
> /etc/grub.source.d/) where add-ons are sourced rather than executed. 

Let's use the same grub.d (in /usr/local/etc for local install and
in /etc for system install).  What we need is a site template and a
vendor template.

I think the templates should be sourced before 00_header.  Maybe the
numbers should be shifted, so that we have 10_site, 20_vendor, 30_header
etc and still have gaps for more stuff.  Or the templates should have a
distinctive suffix.

The assignments should be careful to preserve already set variables.
The assignments should be written like this:

: ${GRUB_CMDLINE_LINUX=foo=bar quux=1}

In some cases, appending more stuff would be preferred, but for
GRUB_CMDLINE_LINUX, it's better to allow the earlier templates or the
environment to cancel the additions.

The site template could be installed unless it's installed already.  Or
it could be installed under a name under which it won't be sourced, and
should have an explanation how to rename it to make it work.

-- 
Regards,
Pavel Roskin



  parent reply	other threads:[~2008-02-12 22:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12  8:32 comments about /etc/default/grub Franklin PIAT
2008-02-12 11:47 ` Robert Millan
2008-02-12 20:54   ` Franklin PIAT
2008-02-12 22:55   ` Pavel Roskin [this message]
2008-02-13 15:56     ` Robert Millan
2008-02-18  4:08       ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1202856910.20992.30.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.