[PATCH] Re: [Xen-staging] [xen-unstable] Enable HVM guest VT-d device hotplug via a simple ACPI hotplug device model.

[Alex Williamson <alex.williamson@hp.com>]

On Fri, 2008-02-15 at 14:14 +0000, Xen staging patchbot-unstable wrote:
> # HG changeset patch
> # User Keir Fraser <keir.fraser@citrix.com>
> # Date 1203084797 0
> # Node ID c6eeb71a85cffe917bc8d6738fd36e6694dba4d6
> # Parent  29c03bc32d3e16103e9cc48260ab83317662a93e
> Enable HVM guest VT-d device hotplug via a simple ACPI hotplug device model.
...
> diff -r 29c03bc32d3e -r c6eeb71a85cf xen/include/public/hvm/ioreq.h
> --- a/xen/include/public/hvm/ioreq.h	Fri Feb 15 12:50:55 2008 +0000
> +++ b/xen/include/public/hvm/ioreq.h	Fri Feb 15 14:13:17 2008 +0000
> @@ -118,6 +118,11 @@ struct buffered_piopage {
>  #define ACPI_PM1A_EVT_BLK_ADDRESS           0x0000000000001f40
>  #define ACPI_PM1A_CNT_BLK_ADDRESS           (ACPI_PM1A_EVT_BLK_ADDRESS + 0x04)
>  #define ACPI_PM_TMR_BLK_ADDRESS             (ACPI_PM1A_EVT_BLK_ADDRESS + 0x08)
> +
> +#define ACPI_GPE0_BLK_ADDRESS               (ACPI_PM_TMR_BLK_ADDRESS + 0x20)
> +
> +#define ACPI_GPE0_BLK_LEN                   0x08
> +
>  #endif /* defined(__i386__) || defined(__x86_64__) */
>  
>  #endif /* _IOREQ_H_ */

   This makes use of some macros that are only defined for i386/x86_64,
so the ia64 build fails on piix4acpi.c.  However, I'm not sure why these
are x86 only, and the cset that made them x86 only doesn't appear to
have any dependency on them.  Things seem to work fine if we enable
these for everyone.  Thanks,

	Alex

Signed-off-by: Alex Williamson <alex.williamson@hp.com>
--

diff -r 1cb8d51b4d77 -r f5ee841085f6 xen/include/public/hvm/ioreq.h
--- a/xen/include/public/hvm/ioreq.h	Fri Feb 15 14:31:20 2008 +0000
+++ b/xen/include/public/hvm/ioreq.h	Fri Feb 15 09:12:55 2008 -0700
@@ -114,7 +114,6 @@ struct buffered_piopage {
 };
 #endif /* defined(__ia64__) */
 
-#if defined(__i386__) || defined(__x86_64__)
 #define ACPI_PM1A_EVT_BLK_ADDRESS           0x0000000000001f40
 #define ACPI_PM1A_CNT_BLK_ADDRESS           (ACPI_PM1A_EVT_BLK_ADDRESS + 0x04)
 #define ACPI_PM_TMR_BLK_ADDRESS             (ACPI_PM1A_EVT_BLK_ADDRESS + 0x08)
@@ -122,8 +121,6 @@ struct buffered_piopage {
 #define ACPI_GPE0_BLK_ADDRESS               (ACPI_PM_TMR_BLK_ADDRESS + 0x20)
 
 #define ACPI_GPE0_BLK_LEN                   0x08
-
-#endif /* defined(__i386__) || defined(__x86_64__) */
 
 #endif /* _IOREQ_H_ */