From: Alex Williamson <alex.williamson@hp.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Re: [Xen-staging] [xen-unstable] Enable HVM guest VT-d device hotplug via a simple ACPI hotplug device model.
Date: Sat, 16 Feb 2008 08:28:36 -0700 [thread overview]
Message-ID: <1203175716.7285.6.camel@bling> (raw)
In-Reply-To: <C3DC4AA2.140BC%Keir.Fraser@cl.cam.ac.uk>
On Sat, 2008-02-16 at 08:09 +0000, Keir Fraser wrote:
> On 15/2/08 16:54, "Alex Williamson" <alex.williamson@hp.com> wrote:
>
> > This makes use of some macros that are only defined for i386/x86_64,
> > so the ia64 build fails on piix4acpi.c. However, I'm not sure why these
> > are x86 only, and the cset that made them x86 only doesn't appear to
> > have any dependency on them. Things seem to work fine if we enable
> > these for everyone. Thanks,
>
> Hmmm... they're x86-specific because they define x86-specific i/o port
> addresses. It may be nicer to more clearly separate out the x86-specific
> code that uses these macros. I'll take a look.
That was my initial thought too, but 12390:430e06e2aa08 is the change
that set the PM1A_EVT_BLK_ADDRESS to it's current value, and it
indicates it's for ia64. So my guess was that we both have this at the
same address. I'm not sure why cset 12390 doesn't make use of the macro
with the acpi_map() call it makes though.
Alex
--
Alex Williamson HP Open Source & Linux Org.
next prev parent reply other threads:[~2008-02-16 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200802151414.m1FEEPtj017583@latara.uk.xensource.com>
2008-02-15 16:54 ` [PATCH] Re: [Xen-staging] [xen-unstable] Enable HVM guest VT-d device hotplug via a simple ACPI hotplug device model Alex Williamson
2008-02-16 8:09 ` Keir Fraser
2008-02-16 15:28 ` Alex Williamson [this message]
2008-02-16 15:56 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203175716.7285.6.camel@bling \
--to=alex.williamson@hp.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.