From: Jonas Bonn <jonas@southpole.se>
To: linux-kernel@vger.kernel.org
Subject: pci_device_id definition cleanups
Date: Sat, 16 Feb 2008 00:21:40 +0100 [thread overview]
Message-ID: <1203117700.16761.9.camel@satguru> (raw)
[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]
I've done some work on cleaning up the definitions of pci_device_id to
make them "static const" (where possible) and to make sure they go into
__devinitconst. There are about 350 changes of the type shown in the
diff at the end of this mail.
All these changes are in my public GIT tree at:
git://www.southpole.se/~jonas/git/linux.git
(Based on 2.6.25-rc2)
In addition to these pci_device_id changes, there are a few changesets
that move "const" data from __devinitdata to __devinitconst.
The tree above builds with both allmodconfig and allyesconfig.
/Jonas
------
Representative example change:
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 4d59ae8..90c7820 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -4967,7 +4967,7 @@ megaraid_shutdown(struct pci_dev *pdev)
__megaraid_shutdown(adapter);
}
-static struct pci_device_id megaraid_pci_tbl[] = {
+static const struct pci_device_id megaraid_pci_tbl[] __devinitconst = {
{PCI_VENDOR_ID_AMI, PCI_DEVICE_ID_AMI_MEGARAID,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{PCI_VENDOR_ID_AMI, PCI_DEVICE_ID_AMI_MEGARAID2,
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2008-02-15 23:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 23:21 Jonas Bonn [this message]
2008-02-16 0:05 ` pci_device_id definition cleanups Greg KH
2008-02-16 0:55 ` Jeff Garzik
2008-02-16 0:57 ` Greg KH
2008-02-16 2:23 ` Sam Ravnborg
2008-02-16 5:27 ` Olof Johansson
2008-02-16 12:24 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203117700.16761.9.camel@satguru \
--to=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.