Re: [PATCH 08/13 v2] o11s: other changes in mac80211 for mesh interface support

[Luis Carlos Cobo <luisca@cozybit.com>]

On Sat, 2008-02-23 at 07:41 +0100, Stefano Brivio wrote:
> I'd like to have this moved, maybe right before this:
> 
>         /* Compute the controller output. */

Ok.

> 
> >  		pf <<= RC_PID_ARITH_SHIFT;
> > +		sta->fail_avg = ((pf + (spinfo->last_pf << 3)) / 9)
> > +					>> RC_PID_ARITH_SHIFT;
> >  	}
> 
> What do you need fail_avg for? Please note that we have better estimates of
> the frame failure trends (e.g., err_avg). What these magic values are?

It's supposed to be an estimation of the probability of a frame
transmission failure. The magic numbers just express the formula

fail_avg = (8 * old_fail_avg + 1 * fail_avg) / 9

a simple smoothing, there is nothing special to the exact numbers.

If you think err_avg is a good candidate (is it also 0-100?) I'd be
happy to use that instead.

-- 
Luis Carlos Cobo Rus       GnuPG ID: 44019B60
cozybit Inc.