From: Luis Carlos Cobo <luisca@cozybit.com>
To: Stefano Brivio <stefano.brivio@polimi.it>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Mattias Nissler <mattias.nissler@gmx.de>
Subject: Re: [PATCH 08/13 v2] o11s: other changes in mac80211 for mesh interface support
Date: Fri, 29 Feb 2008 12:56:46 -0800 [thread overview]
Message-ID: <1204318606.7735.16.camel@localhost> (raw)
In-Reply-To: <20080223074133.32a4609c@morte>
On Sat, 2008-02-23 at 07:41 +0100, Stefano Brivio wrote:
> > +#ifdef CONFIG_MAC80211_MESH
> > + if (pf == 100 &&
> > + sdata->vif.type == IEEE80211_IF_TYPE_MESH_POINT)
> > + mesh_plink_broken(sta);
> > +#endif
>
> I'd like to have this moved, maybe right before this:
Why? pf and tx_num_xmit (which is checked in an if leading to this
lines) are modified between this point and where you want to move the
code. If it is necessary I can add a 'broken link' flag to execute
mesh_plink_broken later.
I think by now I will keep using fail_avg, but if you figure out a
better way to compute a meaningful value please feel free to modify it.
What we need is the probability (value between 0 and 1, now using
integers from 0 to 100 to represent it) that a frame sent in the near
future to this station will fail and will have to be retransmitted.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
prev parent reply other threads:[~2008-02-29 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 4:17 [PATCH 08/13 v2] o11s: other changes in mac80211 for mesh interface support Luis Carlos Cobo
2008-02-22 16:16 ` Johannes Berg
2008-02-25 19:32 ` Luis Carlos Cobo
2008-02-25 19:32 ` Johannes Berg
2008-02-23 6:41 ` Stefano Brivio
2008-02-25 21:15 ` Luis Carlos Cobo
2008-02-26 20:36 ` Stefano Brivio
2008-02-29 20:56 ` Luis Carlos Cobo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204318606.7735.16.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mattias.nissler@gmx.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.