From: Harvey Harrison <harvey.harrison@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
Antonino Daplas <adaplas@gmail.com>
Subject: Re: [PATCH] fbcon: replace mono_col macro with static inline
Date: Tue, 26 Feb 2008 13:50:02 -0800 [thread overview]
Message-ID: <1204062602.5582.38.camel@brick> (raw)
In-Reply-To: <Pine.LNX.4.64.0802262235150.22486@anakin>
On Tue, 2008-02-26 at 22:36 +0100, Geert Uytterhoeven wrote:
> On Tue, 26 Feb 2008, Harvey Harrison wrote:
> > On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote:
> > > On Mon, 25 Feb 2008, Harvey Harrison wrote:
> > > > +static inline int mono_col(struct fb_info *info)
> > > ^^^^^^^^^^^^^^^^^^^^
> > > const struct fb_info *info?
> >
> > I suppose, but seeing as it's an inline, does it really matter?
>
> Sure, if one day a new routine calls mono_col() passing a const struct fb_info
> pointer, it won't compile.
Fair enough, want an updated patch, or will Andrew just make the small
addition?
Harvey
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
WARNING: multiple messages have this Message-ID (diff)
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Antonino Daplas <adaplas@gmail.com>
Subject: Re: [Linux-fbdev-devel] [PATCH] fbcon: replace mono_col macro with static inline
Date: Tue, 26 Feb 2008 13:50:02 -0800 [thread overview]
Message-ID: <1204062602.5582.38.camel@brick> (raw)
In-Reply-To: <Pine.LNX.4.64.0802262235150.22486@anakin>
On Tue, 2008-02-26 at 22:36 +0100, Geert Uytterhoeven wrote:
> On Tue, 26 Feb 2008, Harvey Harrison wrote:
> > On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote:
> > > On Mon, 25 Feb 2008, Harvey Harrison wrote:
> > > > +static inline int mono_col(struct fb_info *info)
> > > ^^^^^^^^^^^^^^^^^^^^
> > > const struct fb_info *info?
> >
> > I suppose, but seeing as it's an inline, does it really matter?
>
> Sure, if one day a new routine calls mono_col() passing a const struct fb_info
> pointer, it won't compile.
Fair enough, want an updated patch, or will Andrew just make the small
addition?
Harvey
next prev parent reply other threads:[~2008-02-26 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 18:13 [PATCH] fbcon: replace mono_col macro with static inline Harvey Harrison
2008-02-25 18:50 ` Andrew Morton
2008-02-25 18:50 ` Andrew Morton
2008-02-26 8:18 ` Geert Uytterhoeven
2008-02-26 8:18 ` Geert Uytterhoeven
2008-02-26 20:51 ` Harvey Harrison
2008-02-26 21:36 ` Geert Uytterhoeven
2008-02-26 21:36 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2008-02-26 21:50 ` Harvey Harrison [this message]
2008-02-26 21:50 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204062602.5582.38.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.