From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: balbir@linux.vnet.ibm.com
Cc: David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [RFC][PATCH] page reclaim throttle take2
Date: Wed, 27 Feb 2008 10:44:58 +0100 [thread overview]
Message-ID: <1204105498.6242.374.camel@lappy> (raw)
In-Reply-To: <47C526F8.8010807@linux.vnet.ibm.com>
On Wed, 2008-02-27 at 14:31 +0530, Balbir Singh wrote:
> You mentioned CONFIG_NUM_RECLAIM_THREADS_PER_CPU and not
> CONFIG_NUM_RECLAIM_THREADS_PER_NODE. The advantage with syscalls is that even if
> we get the thing wrong, the system administrator has an alternative. Please look
> through the existing sysctl's and you'll see what I mean. What is wrong with
> providing the flexibility that comes with sysctl? We cannot possibly think of
> all situations and come up with the right answer for a heuristic. Why not come
> up with a default and let everyone use what works for them?
I agree with Balbir, just turn it into a sysctl, its easy enough to do,
and those who need it will thank you for it instead of curse you for
hard coding it.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: balbir@linux.vnet.ibm.com
Cc: David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Rik van Riel <riel@redhat.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [RFC][PATCH] page reclaim throttle take2
Date: Wed, 27 Feb 2008 10:44:58 +0100 [thread overview]
Message-ID: <1204105498.6242.374.camel@lappy> (raw)
In-Reply-To: <47C526F8.8010807@linux.vnet.ibm.com>
On Wed, 2008-02-27 at 14:31 +0530, Balbir Singh wrote:
> You mentioned CONFIG_NUM_RECLAIM_THREADS_PER_CPU and not
> CONFIG_NUM_RECLAIM_THREADS_PER_NODE. The advantage with syscalls is that even if
> we get the thing wrong, the system administrator has an alternative. Please look
> through the existing sysctl's and you'll see what I mean. What is wrong with
> providing the flexibility that comes with sysctl? We cannot possibly think of
> all situations and come up with the right answer for a heuristic. Why not come
> up with a default and let everyone use what works for them?
I agree with Balbir, just turn it into a sysctl, its easy enough to do,
and those who need it will thank you for it instead of curse you for
hard coding it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-02-27 9:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 2:32 [RFC][PATCH] page reclaim throttle take2 KOSAKI Motohiro
2008-02-26 2:32 ` KOSAKI Motohiro
2008-02-26 21:18 ` Peter Zijlstra
2008-02-26 21:18 ` Peter Zijlstra
2008-02-27 0:50 ` KAMEZAWA Hiroyuki
2008-02-27 0:50 ` KAMEZAWA Hiroyuki
2008-02-27 4:26 ` KOSAKI Motohiro
2008-02-27 4:26 ` KOSAKI Motohiro
2008-02-27 4:27 ` Balbir Singh
2008-02-27 4:27 ` Balbir Singh
2008-02-27 4:45 ` KOSAKI Motohiro
2008-02-27 4:45 ` KOSAKI Motohiro
2008-02-27 5:00 ` KAMEZAWA Hiroyuki
2008-02-27 5:00 ` KAMEZAWA Hiroyuki
2008-02-27 5:04 ` KOSAKI Motohiro
2008-02-27 5:04 ` KOSAKI Motohiro
2008-02-27 5:03 ` Balbir Singh
2008-02-27 5:03 ` Balbir Singh
2008-02-27 5:13 ` KOSAKI Motohiro
2008-02-27 5:13 ` KOSAKI Motohiro
2008-02-27 5:19 ` David Rientjes
2008-02-27 5:19 ` David Rientjes
2008-02-27 5:33 ` KOSAKI Motohiro
2008-02-27 5:33 ` KOSAKI Motohiro
2008-02-27 5:47 ` David Rientjes
2008-02-27 5:47 ` David Rientjes
2008-02-27 5:48 ` Balbir Singh
2008-02-27 5:48 ` Balbir Singh
2008-02-27 6:09 ` David Rientjes
2008-02-27 6:09 ` David Rientjes
2008-02-27 7:10 ` KOSAKI Motohiro
2008-02-27 7:10 ` KOSAKI Motohiro
2008-02-27 7:19 ` David Rientjes
2008-02-27 7:19 ` David Rientjes
2008-02-27 7:51 ` KAMEZAWA Hiroyuki
2008-02-27 7:51 ` KAMEZAWA Hiroyuki
2008-02-27 7:56 ` David Rientjes
2008-02-27 7:56 ` David Rientjes
2008-02-27 8:09 ` KAMEZAWA Hiroyuki
2008-02-27 8:09 ` KAMEZAWA Hiroyuki
2008-02-27 15:30 ` Rik van Riel
2008-02-27 15:30 ` Rik van Riel
2008-02-27 7:59 ` Balbir Singh
2008-02-27 7:59 ` Balbir Singh
2008-02-27 8:47 ` David Rientjes
2008-02-27 8:47 ` David Rientjes
2008-02-27 9:01 ` Balbir Singh
2008-02-27 9:01 ` Balbir Singh
2008-02-27 9:44 ` Peter Zijlstra [this message]
2008-02-27 9:44 ` Peter Zijlstra
2008-02-27 6:52 ` KOSAKI Motohiro
2008-02-27 6:52 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204105498.6242.374.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=Lee.Schermerhorn@hp.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.