[PATCH] mm/slab.c - use angle brackets for include

[PATCH] mm/slab.c - use angle brackets for include

[Joe Perches]

Signed-off-by: Joe Perches <joe@perches.com>

mm/slab.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 473e6c2..a37f897 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -333,7 +333,7 @@ static __always_inline int index_of(const size_t size)
 		return i; \
 	else \
 		i++;
-#include "linux/kmalloc_sizes.h"
+#include <linux/kmalloc_sizes.h>
 #undef CACHE
 		__bad_size();
 	} else

[PATCH] mm/slab.c - use angle brackets for include

[Joe Perches]

mm/slab.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 473e6c2..a37f897 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -333,7 +333,7 @@ static __always_inline int index_of(const size_t size)
 		return i; \
 	else \
 		i++;
-#include "linux/kmalloc_sizes.h"
+#include <linux/kmalloc_sizes.h>
 #undef CACHE
 		__bad_size();
 	} else



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/slab.c - use angle brackets for include

[Joe Perches]

On Wed, 2008-03-05 at 12:53 -0800, Christoph Lameter wrote:
> On Wed, 5 Mar 2008, Joe Perches wrote:
> > net/netfilter/nf_conntrack_extend.c:26:#include <linux/kmalloc_sizes.h>
> Urgh look at that:

:) at least it's noted as "horrible".

> Guess we need to define a constant KMALLC_MIN_SIZE in include/sl?b_def.h 
> to get rid of this hack?

Seems a likely idea, but maybe netfilter shouldn't bother
with a minimum?

Re: [PATCH] mm/slab.c - use angle brackets for include

[Pekka Enberg]

Joe Perches wrote:
> Seems a likely idea, but maybe netfilter shouldn't bother
> with a minimum?

Agreed and sent a patch to do just that.