All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jon Schindler <jkschind@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	trivial@kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/11] /drivers/char/ip2/ip2main.c replaced
Date: Wed, 05 Mar 2008 06:28:18 +0000	[thread overview]
Message-ID: <1204698498.17484.4.camel@brick> (raw)
In-Reply-To: <47CE3466.5050306@watson.wustl.edu>

On Tue, 2008-03-04 at 23:49 -0600, Jon Schindler wrote:
> Replaced init_module and cleanup_module with static functions and module_init/module_exit.
> 

trivial comments

>  #ifdef MODULE
> -int
> -init_module(void)
> +static int __init
> +ip2_init_module(void)
>  {

+static int __init ip2_init_module(void)

> ****************************************************************/
>  #ifdef MODULE
> -void
> -cleanup_module(void)
> +void __exit
> +ip2_cleanup_module(void)
>  {

+void __exit ip2_cleanup_module(void)

Cheers,

Harvey


WARNING: multiple messages have this Message-ID (diff)
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Jon Schindler <jkschind@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	trivial@kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/11] /drivers/char/ip2/ip2main.c replaced init_module&cleanup_module with module_init&module_exit
Date: Tue, 04 Mar 2008 22:28:18 -0800	[thread overview]
Message-ID: <1204698498.17484.4.camel@brick> (raw)
In-Reply-To: <47CE3466.5050306@watson.wustl.edu>

On Tue, 2008-03-04 at 23:49 -0600, Jon Schindler wrote:
> Replaced init_module and cleanup_module with static functions and module_init/module_exit.
> 

trivial comments

>  #ifdef MODULE
> -int
> -init_module(void)
> +static int __init
> +ip2_init_module(void)
>  {

+static int __init ip2_init_module(void)

> ****************************************************************/
>  #ifdef MODULE
> -void
> -cleanup_module(void)
> +void __exit
> +ip2_cleanup_module(void)
>  {

+void __exit ip2_cleanup_module(void)

Cheers,

Harvey


  reply	other threads:[~2008-03-05  6:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05  5:49 [PATCH 3/11] /drivers/char/ip2/ip2main.c replaced init_module&cleanup_module Jon Schindler
2008-03-05  5:49 ` [PATCH 3/11] /drivers/char/ip2/ip2main.c replaced init_module&cleanup_module with module_init&module_exit Jon Schindler
2008-03-05  6:28 ` Harvey Harrison [this message]
2008-03-05  6:28   ` Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204698498.17484.4.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jkschind@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.