From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] cdrom access patch
Date: Mon, 17 Mar 2008 00:31:03 -0400 [thread overview]
Message-ID: <1205728263.2220.10.camel@dv> (raw)
In-Reply-To: <ca0f59980803150034t5faf16dek227dffe156b3c9fc@mail.gmail.com>
On Sat, 2008-03-15 at 15:34 +0800, Bean wrote:
> Ok, the new patch add (cd0) alias for cdrom device, the corresponding
> (hdN) is also present.
...
> (grub_biosdisk_call_hook): Only handle (hdN) device name.
I still don't understand this part. Maybe you could split your patch
into smaller parts?
Suppose we hard drives at 0x80 and 0x82 and a CD at 0x90. We can call
grub_biosdisk_get_cdinfo_int13_extension() and figure out that 0x90 is
the boot CD, so we call it (cd0). Then we go through the drives and
call them (hd0), (hd1).
If it's OK to have an alias, why not suppress of hide the original name?
At what point do we need to use the _name_ to calculate the BIOS number?
Why cannot we simply store that number into some field?
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-03-17 4:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 8:49 [PATCH] cdrom access patch Bean
2008-03-07 15:37 ` Vesa Jääskeläinen
2008-03-09 15:33 ` Bean
2008-03-10 15:53 ` Bean
2008-03-11 21:10 ` Christian Franke
2008-03-12 5:26 ` Bean
2008-03-12 6:52 ` Christian Franke
2008-03-13 22:59 ` Christian Franke
2008-03-14 5:33 ` Bean
2008-03-14 17:28 ` Pavel Roskin
2008-03-14 19:58 ` Bean
2008-03-14 20:56 ` Bean
2008-03-14 20:58 ` Vesa Jääskeläinen
2008-03-15 7:34 ` Bean
2008-03-15 8:49 ` Vesa Jääskeläinen
2008-03-15 10:54 ` Bean
2008-03-15 19:01 ` Christian Franke
2008-03-17 4:31 ` Pavel Roskin [this message]
2008-03-17 6:21 ` Bean
2008-03-19 22:09 ` Pavel Roskin
2008-03-20 6:06 ` Bean
2008-03-24 4:15 ` Bean
2008-03-14 23:20 ` Christian Franke
-- strict thread matches above, loose matches on Subject: below --
2008-03-06 23:58 Kalamatee
2008-03-08 20:16 Kalamatee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205728263.2220.10.camel@dv \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.