From: Hollis Blanchard <hollisb@us.ibm.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [kvm-ppc-devel] broken DTS syntax
Date: Fri, 28 Mar 2008 16:10:45 +0000 [thread overview]
Message-ID: <1206720645.5432.1.camel@basalt> (raw)
On Fri, 2008-03-28 at 10:32 -0500, Jerone Young wrote:
> > paelzer@HeliosPrime
> ~/Desktop/KVM/ppc_port/kvm-userspace-vio/qemu/pc-bios $ dtc -I dts -O
> dtb -o bamboo.dtb2 bamboo.dts
> > DTC: dts->dtb on file "bamboo.dts"
> > bamboo.dts:20 syntax error
> > FATAL ERROR: Couldn't read input tree
> >
> > Is this correct/expected atm or do we have to fix something here
> before this goes upstream ?
> >
>
> This must be a dtc versioning issue. My version of dtc compiles the
> code
> fine without issue. But you may have a really older version. Hollis
> had
> spotted a bit of the same problem yesterday.
>
> I am using dtc version:
> dtc -v
> Version: DTC 1.1.0-g2512a7eb
>
>
> Are you using an older version then this one. If so time for everyone
> to upgrade.
Interesting, I didn't realize the syntax had changed.
However, since it's just a matter of 4 characters, I think it's not too
much trouble to support the older DTC versions as well.
For reference, this is the fix:
diff -u b/qemu/pc-bios/bamboo.dts b/qemu/pc-bios/bamboo.dts
--- b/qemu/pc-bios/bamboo.dts
+++ b/qemu/pc-bios/bamboo.dts
@@ -17,8 +17,8 @@
dcr-parent = <&/cpus/cpu@0>;
aliases {
- serial0 = &UART0;
- serial1 = &UART1;
+ serial0 = <&UART0>;
+ serial1 = <&UART1>;
};
cpus {
--
Hollis Blanchard
IBM Linux Technology Center
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel
reply other threads:[~2008-03-28 16:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206720645.5432.1.camel@basalt \
--to=hollisb@us.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.