From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [PATCH 1/5] fs/gfs2: test for IS_ERR rather than 0
Date: Mon, 31 Mar 2008 11:35:43 +0100 [thread overview]
Message-ID: <1206959743.3635.123.camel@quoit> (raw)
In-Reply-To: <Pine.LNX.4.64.0803241908210.32740@ask.diku.dk>
Hi,
On Mon, 2008-03-24 at 19:08 +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The function gfs2_inode_lookup always returns either a valid pointer or a
> value made with ERR_PTR, so its result should be tested with IS_ERR, not
> with a test for 0.
>
Sorry for the delay - I've just got back from holiday. Its now in the
GFS2 -nmw git tree. Also I updated the tree to the latest Linus git tree
at the same time. Thanks,
Steve.
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/5] fs/gfs2: test for IS_ERR rather than 0
Date: Mon, 31 Mar 2008 10:35:43 +0000 [thread overview]
Message-ID: <1206959743.3635.123.camel@quoit> (raw)
In-Reply-To: <Pine.LNX.4.64.0803241908210.32740@ask.diku.dk>
Hi,
On Mon, 2008-03-24 at 19:08 +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The function gfs2_inode_lookup always returns either a valid pointer or a
> value made with ERR_PTR, so its result should be tested with IS_ERR, not
> with a test for 0.
>
Sorry for the delay - I've just got back from holiday. Its now in the
GFS2 -nmw git tree. Also I updated the tree to the latest Linus git tree
at the same time. Thanks,
Steve.
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Julia Lawall <julia@diku.dk>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/5] fs/gfs2: test for IS_ERR rather than 0
Date: Mon, 31 Mar 2008 11:35:43 +0100 [thread overview]
Message-ID: <1206959743.3635.123.camel@quoit> (raw)
In-Reply-To: <Pine.LNX.4.64.0803241908210.32740@ask.diku.dk>
Hi,
On Mon, 2008-03-24 at 19:08 +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The function gfs2_inode_lookup always returns either a valid pointer or a
> value made with ERR_PTR, so its result should be tested with IS_ERR, not
> with a test for 0.
>
Sorry for the delay - I've just got back from holiday. Its now in the
GFS2 -nmw git tree. Also I updated the tree to the latest Linus git tree
at the same time. Thanks,
Steve.
next prev parent reply other threads:[~2008-03-31 10:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 18:08 [PATCH 1/5] fs/gfs2: test for IS_ERR rather than 0 Julia Lawall
2008-03-24 18:08 ` Julia Lawall
2008-03-31 10:35 ` Steven Whitehouse [this message]
2008-03-31 10:35 ` Steven Whitehouse
2008-03-31 10:35 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206959743.3635.123.camel@quoit \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.