From: Joe Perches <joe@perches.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH 6/8] e1000e: convert ndev_ printks to something smaller
Date: Mon, 31 Mar 2008 12:09:39 -0700 [thread overview]
Message-ID: <1206990579.23161.32.camel@localhost> (raw)
In-Reply-To: <47F12F27.802@intel.com>
On Mon, 2008-03-31 at 11:36 -0700, Kok, Auke wrote:
> yes and I even tried pushing for a generic netdev printk that incorporates the
> msg_enable bits properly
>
> I also got absolutely unwelcome responses to that, if not none :)
http://www.mail-archive.com/netdev@vger.kernel.org/msg40070.html
It still makes sense to me.
I think the overall amount of churn is low,
readability would improve, existing errors in
msg_enable would be eliminated during the churn
and the newly introduced error rate would be lower.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2008-03-31 19:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 16:15 [PATCH 1/8] e1000e: reformat comment blocks, cosmetic changes only Auke Kok
2008-03-28 16:15 ` [PATCH 2/8] e1000e: rename mc_addr_list_update Auke Kok
2008-03-28 16:15 ` [PATCH 3/8] e1000e: reorganize PHY and flow control interface Auke Kok
2008-03-28 16:15 ` [PATCH 4/8] e1000e: limit EEPROM size accesses Auke Kok
2008-03-29 1:58 ` Jeff Garzik
2008-03-31 16:33 ` Kok, Auke
2008-03-28 16:15 ` [PATCH 5/8] e1000e: Make arrays out of these Rx/Tx registers Auke Kok
2008-03-28 16:15 ` [PATCH 6/8] e1000e: convert ndev_ printks to something smaller Auke Kok
2008-03-29 2:03 ` Jeff Garzik
2008-03-31 18:36 ` Kok, Auke
2008-03-31 19:09 ` Joe Perches [this message]
2008-04-02 18:55 ` [E1000-devel] " Kok, Auke
2008-03-28 16:15 ` [PATCH 7/8] e1000e: rename a few functions Auke Kok
2008-03-28 16:15 ` [PATCH 8/8] e1000e: reformat register test code, fix some minor initialization Auke Kok
2008-03-29 2:16 ` [PATCH 1/8] e1000e: reformat comment blocks, cosmetic changes only Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206990579.23161.32.camel@localhost \
--to=joe@perches.com \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.