Re: [PATCH 13/18] mac80211: mesh statistics and config through debugfs

[Luis Carlos Cobo <luisca@cozybit.com>]

On Thu, 2008-03-27 at 23:16 -0700, Andrew Morton wrote:
> - then fix the obvious, trivial, instantly-detectable, very-deadlocka=
ble
>   bug in this patch.  There is just no longer any excuse for this:
>=20
> +	read_lock(&dev_base_lock);
> +	if (copy_from_user(buf, userbuf, buf_size))

=EF=BB=BFAs the author of the patch, I would like to apologize about th=
is.=20

Regarding review quality, I would like to point out that the function
just above this one, ieee80211_if_read(), which has been for a while in
the stable releases, suffers the same problem. That does not excuse
myself though, I should have spotted and fixed it and then implement
ieee80211_if_write() properly. I will send a patch fixing both issues
today.

Again sorry for the mess and thank you for spotting the problem.

--=20
Luis Carlos Cobo Rus       GnuPG ID: 44019B60
cozybit Inc.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html