Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2008-04-01 at 19:15 +1100, Nigel Cunningham wrote:
> > + *   However, drivers may NOT assume anything about the availability of the
> > + *   user space at that time and it is not correct to request firmware from
> > + *   within @prepare() (it's too late to do that).
> 
> That doesn't sound good. It would be good to be able to get drivers to
> request firmware early in the process.

Agreed. Prepare() should still allow request_firmware and full userspace
communication / helper usage.

> > + * @complete: Undo the changes made by @prepare().  This method is executed for
> > + *   all kinds of resume transitions, following one of the resume callbacks:
> > + *   @resume(), @thaw(), @restore().  Also called if the state transition
> > + *   fails before the driver's suspend callback (@suspend(), @freeze(),
> > + *   @poweroff()) can be executed (e.g. if the suspend callback fails for one
> > + *   of the other devices that the PM core has unsucessfully attempted to

Ben.