All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/3] xen: Fix oops when mapping/unmapping addr above 1Gb
Date: Wed, 02 Apr 2008 15:35:43 +0100	[thread overview]
Message-ID: <1207146943.11911.1.camel@muff> (raw)
In-Reply-To: <47F0FB5F.2000908@goop.org>

On Mon, 2008-03-31 at 07:55 -0700, Jeremy Fitzhardinge wrote:
> Ingo Molnar wrote:
> > * Mark McLoughlin <markmc@redhat.com> wrote:
> >   
> >>         In Fedora rawhide we're currently seeing oopses whenever a 
> >> processes dlopen()s a library which prelink() has previously relocated 
> >> above 1Gb. Some more details at:
> >>
> >>   https://bugzilla.redhat.com/436453
> >>
> >>         The issue seems to be that during xen_pgd_pin(), we only pin 
> >> PTE pages, but xen's release_pmd() tries to unpin PMD pages too.
> >>
> >>         The following series of patches is against the latest x86 
> >> tree.
> >>     
> >
> > thanks, i've picked them up to get them tested - but it would be nice to 
> > have an ack from Jeremy as well. This seems like v2.6.25 material as 
> > well, right?
> 
> Didn't I reply?  Anyway, the patch looks good.  It's definitely 2.6.25 
> material; its fallout from the changes I did to dynamically 
> allocate/deallocate pmds rather than always do them with the pgd.

Okay, here are the patches rebased to 2.6.25-rc8.

I've reproduced the issue with plain -rc8 and confirmed the patches fix
it.

Cheers,
Mark.


WARNING: multiple messages have this Message-ID (diff)
From: Mark McLoughlin <markmc@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	xen-devel@lists.xensource.com,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 0/3] xen: Fix oops when mapping/unmapping addr above 1Gb
Date: Wed, 02 Apr 2008 15:35:43 +0100	[thread overview]
Message-ID: <1207146943.11911.1.camel@muff> (raw)
In-Reply-To: <47F0FB5F.2000908@goop.org>

On Mon, 2008-03-31 at 07:55 -0700, Jeremy Fitzhardinge wrote:
> Ingo Molnar wrote:
> > * Mark McLoughlin <markmc@redhat.com> wrote:
> >   
> >>         In Fedora rawhide we're currently seeing oopses whenever a 
> >> processes dlopen()s a library which prelink() has previously relocated 
> >> above 1Gb. Some more details at:
> >>
> >>   https://bugzilla.redhat.com/436453
> >>
> >>         The issue seems to be that during xen_pgd_pin(), we only pin 
> >> PTE pages, but xen's release_pmd() tries to unpin PMD pages too.
> >>
> >>         The following series of patches is against the latest x86 
> >> tree.
> >>     
> >
> > thanks, i've picked them up to get them tested - but it would be nice to 
> > have an ack from Jeremy as well. This seems like v2.6.25 material as 
> > well, right?
> 
> Didn't I reply?  Anyway, the patch looks good.  It's definitely 2.6.25 
> material; its fallout from the changes I did to dynamically 
> allocate/deallocate pmds rather than always do them with the pgd.

Okay, here are the patches rebased to 2.6.25-rc8.

I've reproduced the issue with plain -rc8 and confirmed the patches fix
it.

Cheers,
Mark.

  reply	other threads:[~2008-04-02 14:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28 16:38 [PATCH 0/3] xen: Fix oops when mapping/unmapping addr above 1Gb Mark McLoughlin
2008-03-28 16:38 ` Mark McLoughlin
2008-03-28 16:38 ` [PATCH 1/3] xen: Refactor xen_{alloc,release}_{pte,pmd}() Mark McLoughlin
2008-03-28 16:38   ` [PATCH 1/3] xen: Refactor xen_{alloc, release}_{pte, pmd}() Mark McLoughlin
2008-03-28 16:38   ` [PATCH 2/3] xen: Do not pin/unpin PMD pages Mark McLoughlin
2008-03-28 16:38     ` Mark McLoughlin
2008-03-28 16:38     ` [PATCH 3/3] xen: Clear PG_pinned in release_{pte,pmd}() Mark McLoughlin
2008-03-28 16:38       ` [PATCH 3/3] xen: Clear PG_pinned in release_{pte, pmd}() Mark McLoughlin
2008-03-28 18:02 ` [PATCH 0/3] xen: Fix oops when mapping/unmapping addr above 1Gb Jeremy Fitzhardinge
2008-03-28 18:02   ` Jeremy Fitzhardinge
2008-03-31 13:14 ` Ingo Molnar
2008-03-31 14:55   ` Jeremy Fitzhardinge
2008-04-02 14:35     ` Mark McLoughlin [this message]
2008-04-02 14:35       ` Mark McLoughlin
2008-04-02 14:36       ` [PATCH 1/3] xen: Refactor xen_{alloc,release}_{pt,pd}() Mark McLoughlin
2008-04-02 14:36         ` [PATCH 1/3] xen: Refactor xen_{alloc, release}_{pt, pd}() Mark McLoughlin
2008-04-02 14:36         ` [PATCH 2/3] xen: Do not pin/unpin PMD pages Mark McLoughlin
2008-04-02 14:36           ` Mark McLoughlin
2008-04-02 14:36           ` [PATCH 3/3] xen: Clear PG_pinned in release_{pt,pd}() Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207146943.11911.1.camel@muff \
    --to=markmc@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.