* [PATCH 1/7] virtio: fix sparse return void-valued expression warnings
@ 2008-04-03 0:33 Harvey Harrison
2008-04-03 22:51 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-04-03 0:33 UTC (permalink / raw)
To: rusty@rustcorp.com.au; +Cc: Andrew Morton, LKML, Al Viro
drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued expression
drivers/virtio/virtio_pci.c:155:2: warning: returning void-valued expression
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/virtio/virtio_pci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index c0df924..de102a6 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -145,14 +145,14 @@ static void vp_set_status(struct virtio_device *vdev, u8 status)
struct virtio_pci_device *vp_dev = to_vp_device(vdev);
/* We should never be setting status to 0. */
BUG_ON(status == 0);
- return iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
+ iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
}
static void vp_reset(struct virtio_device *vdev)
{
struct virtio_pci_device *vp_dev = to_vp_device(vdev);
/* 0 status means a reset. */
- return iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
+ iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS);
}
/* the notify function used when creating a virt queue */
--
1.5.5.rc1.135.g8527
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/7] virtio: fix sparse return void-valued expression warnings
2008-04-03 0:33 [PATCH 1/7] virtio: fix sparse return void-valued expression warnings Harvey Harrison
@ 2008-04-03 22:51 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2008-04-03 22:51 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Andrew Morton, LKML, Al Viro
On Thursday 03 April 2008 10:33:34 Harvey Harrison wrote:
> drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued
> expression drivers/virtio/virtio_pci.c:155:2: warning: returning
> void-valued expression
Hi Harvey,
This patch is in my tree, thanks.
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-03 22:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-03 0:33 [PATCH 1/7] virtio: fix sparse return void-valued expression warnings Harvey Harrison
2008-04-03 22:51 ` Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.