* [PATCH] ata/sata_fsl: Remove unused variable in sata_fsl_probe
@ 2008-04-06 13:10 Johann Felix Soden
0 siblings, 0 replies; only message in thread
From: Johann Felix Soden @ 2008-04-06 13:10 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, Daniel Marjamäki
From: Johann Felix Soden <johfel@users.sourceforge.net>
In sata_fsl_probe memory is allocated but never used or deallocated.
Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=10404
Thanks to Daniel Marjamäki for the bug report.
Reported-by: Daniel Marjamäki <danielm77@spray.se>
Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
---
drivers/ata/sata_fsl.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 4c19855..9d1e3ca 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1256,7 +1256,6 @@ static int sata_fsl_probe(struct of_device *ofdev,
void __iomem *ssr_base = NULL;
void __iomem *csr_base = NULL;
struct sata_fsl_host_priv *host_priv = NULL;
- struct resource *r;
int irq;
struct ata_host *host;
@@ -1266,8 +1265,6 @@ static int sata_fsl_probe(struct of_device *ofdev,
dev_printk(KERN_INFO, &ofdev->dev,
"Sata FSL Platform/CSB Driver init\n");
- r = kmalloc(sizeof(struct resource), GFP_KERNEL);
-
hcr_base = of_iomap(ofdev->node, 0);
if (!hcr_base)
goto error_exit_with_cleanup;
--
1.5.4.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-06 13:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-06 13:10 [PATCH] ata/sata_fsl: Remove unused variable in sata_fsl_probe Johann Felix Soden
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.