From: Benjamin Herrenschmidt <benh@ozlabs.org>
To: Meelis Roos <mroos@linux.ee>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>
Subject: Re: compile failure in pata_sil680.c
Date: Wed, 09 Apr 2008 06:55:36 +1000 [thread overview]
Message-ID: <1207688136.10388.542.camel@pasglop> (raw)
In-Reply-To: <Pine.SOC.4.64.0804081640100.28938@math.ut.ee>
On Tue, 2008-04-08 at 16:44 +0300, Meelis Roos wrote:
> commit 0f436eff54f90419ac1b8accfb3e6e17c4b49a4e introduces the following
> compile failure on ppc (not powerpc), prep subarch. Seems that
> machine_is is only defined in the new powerpc arch.
>
> drivers/ata/pata_sil680.c: In function 'sil680_init_chip':
> drivers/ata/pata_sil680.c:274: error: implicit declaration of function 'machine_is'
> drivers/ata/pata_sil680.c:274: error: 'cell' undeclared (first use in this function)
> drivers/ata/pata_sil680.c:274: error: (Each undeclared identifier is reported only once
> drivers/ata/pata_sil680.c:274: error: for each function it appears in.)
> make[2]: *** [drivers/ata/pata_sil680.o] Error 1
Argh. We still haven't got rid of arch/ppc...
Fix is to replace CONFIG_PPC with CONFIG_PPC_MERGE.
I'll send a patch.
Ben.
prev parent reply other threads:[~2008-04-08 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 13:44 compile failure in pata_sil680.c Meelis Roos
2008-04-08 20:55 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207688136.10388.542.camel@pasglop \
--to=benh@ozlabs.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.