* compile failure in pata_sil680.c
@ 2008-04-08 13:44 Meelis Roos
2008-04-08 20:55 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Meelis Roos @ 2008-04-08 13:44 UTC (permalink / raw)
To: Linux Kernel list, Benjamin Herrenschmidt, Jeff Garzik
commit 0f436eff54f90419ac1b8accfb3e6e17c4b49a4e introduces the following
compile failure on ppc (not powerpc), prep subarch. Seems that
machine_is is only defined in the new powerpc arch.
drivers/ata/pata_sil680.c: In function 'sil680_init_chip':
drivers/ata/pata_sil680.c:274: error: implicit declaration of function 'machine_is'
drivers/ata/pata_sil680.c:274: error: 'cell' undeclared (first use in this function)
drivers/ata/pata_sil680.c:274: error: (Each undeclared identifier is reported only once
drivers/ata/pata_sil680.c:274: error: for each function it appears in.)
make[2]: *** [drivers/ata/pata_sil680.o] Error 1
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: compile failure in pata_sil680.c
2008-04-08 13:44 compile failure in pata_sil680.c Meelis Roos
@ 2008-04-08 20:55 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2008-04-08 20:55 UTC (permalink / raw)
To: Meelis Roos; +Cc: Linux Kernel list, Jeff Garzik
On Tue, 2008-04-08 at 16:44 +0300, Meelis Roos wrote:
> commit 0f436eff54f90419ac1b8accfb3e6e17c4b49a4e introduces the following
> compile failure on ppc (not powerpc), prep subarch. Seems that
> machine_is is only defined in the new powerpc arch.
>
> drivers/ata/pata_sil680.c: In function 'sil680_init_chip':
> drivers/ata/pata_sil680.c:274: error: implicit declaration of function 'machine_is'
> drivers/ata/pata_sil680.c:274: error: 'cell' undeclared (first use in this function)
> drivers/ata/pata_sil680.c:274: error: (Each undeclared identifier is reported only once
> drivers/ata/pata_sil680.c:274: error: for each function it appears in.)
> make[2]: *** [drivers/ata/pata_sil680.o] Error 1
Argh. We still haven't got rid of arch/ppc...
Fix is to replace CONFIG_PPC with CONFIG_PPC_MERGE.
I'll send a patch.
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-08 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-08 13:44 compile failure in pata_sil680.c Meelis Roos
2008-04-08 20:55 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.