All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: Patrick McHardy <kaber@trash.net>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 6/8] [NETFILTER]: Make Ebtables use Xtables infrastructure
Date: Thu, 10 Apr 2008 22:11:46 +0200	[thread overview]
Message-ID: <1207858306.2899.8.camel@localhost.localdomain> (raw)
In-Reply-To: <47FCBFBF.5020805@trash.net>

Op wo, 09-04-2008 te 15:08 +0200, schreef Patrick McHardy:
> Jan Engelhardt wrote:
> > Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> 
> 
> I like these patches (modulo the small NFPROTO_ARP nitpicks),
> I'd like to get an ACK from Bart before applying them though.
> 
> I assume this doesn't affect userspace compatibility?

I'm wondering why the checks for the size of the match info is removed
in every module, except for the among match. This seems strange to me.
If it isn't wrong, I presume there is an obvious way for someone to find
out this is required?
I didn't check the xtables specific stuff too much but I presume Jan
tested this with a released ebtables version...
It looks fine to me from a backwards compatibility point of view.

cheers,
Bart



  parent reply	other threads:[~2008-04-10 20:11 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08 15:31 [PATCH 1/8] [NETFILTER]: Rename ipt_recent to xt_recent Jan Engelhardt
2008-04-08 15:31 ` [PATCH 2/8] [NETFILTER]: xt_recent: IPv6 support Jan Engelhardt
2008-04-09 12:48   ` Patrick McHardy
2008-04-09 13:30     ` Patrick McHardy
2008-04-09 13:44       ` Jan Engelhardt
2008-04-09 13:48         ` Patrick McHardy
2008-04-08 15:31 ` [PATCH 3/8] [NETFILTER]: rename NF_ARP to NFPROTO_ARP and assign a non-clashing value Jan Engelhardt
2008-04-09 12:52   ` Patrick McHardy
2008-04-09 13:09     ` Jan Engelhardt
2008-04-09 13:12       ` Patrick McHardy
2008-04-09 13:17         ` Jan Engelhardt
2008-04-09 13:21           ` Patrick McHardy
2008-04-09 13:34             ` Jan Engelhardt
2008-04-09 13:42               ` Patrick McHardy
2008-04-09 13:48                 ` Jan Engelhardt
2008-04-09 13:51                   ` Patrick McHardy
2008-04-09 13:59                     ` Jan Engelhardt
2008-04-09 14:30                       ` Patrick McHardy
2008-04-09 14:39                         ` Jan Engelhardt
2008-04-09 14:57                           ` Patrick McHardy
2008-04-09 15:12                             ` Jan Engelhardt
2008-04-09 15:15                               ` Patrick McHardy
2008-04-09 16:31                                 ` Jan Engelhardt
2008-04-09 16:35                                   ` Patrick McHardy
2008-04-09 16:46                                     ` Jan Engelhardt
2008-04-09 16:50                                       ` Patrick McHardy
2008-04-09 16:59                                         ` Jan Engelhardt
2008-04-09 17:05                                           ` Patrick McHardy
2008-04-09 17:38                                             ` Jan Engelhardt
2008-04-10  1:10                                               ` Patrick McHardy
2008-04-08 15:31 ` [PATCH 4/8] [NETFILTER]: Implement AF_UNSPEC as a wildcard for extensions Jan Engelhardt
2008-04-08 15:31 ` [PATCH 5/8] [NETFILTER]: Give AF-independent extensions an arpt_ alias Jan Engelhardt
2008-04-08 15:31 ` [PATCH 6/8] [NETFILTER]: Make Ebtables use Xtables infrastructure Jan Engelhardt
2008-04-09 13:08   ` Patrick McHardy
2008-04-09 13:12     ` Jan Engelhardt
2008-04-09 16:52     ` Jan Engelhardt
2008-04-10 20:11     ` Bart De Schuymer [this message]
2008-04-10 20:52       ` Jan Engelhardt
2008-04-13  5:24         ` Patrick McHardy
2008-04-08 15:31 ` [PATCH 7/8] [NETFILTER]: Collapse tcpmss_reverse_mtu{4,6} into one function Jan Engelhardt
2008-04-15 12:51   ` Patrick McHardy
2008-04-15 13:57     ` Jan Engelhardt
2008-04-15 13:59       ` Patrick McHardy
2008-04-08 15:31 ` [PATCH 8/8] [NETFILTER]: Deploy a prefix_length-to-network mask mapping table Jan Engelhardt
2008-04-09 12:45 ` [PATCH 1/8] [NETFILTER]: Rename ipt_recent to xt_recent Patrick McHardy
2008-04-09 12:50   ` Jan Engelhardt
2008-04-09 12:53     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207858306.2899.8.camel@localhost.localdomain \
    --to=bdschuym@pandora.be \
    --cc=jengelh@computergmbh.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.