Re: [PATCH 2/8] [NETFILTER]: xt_recent: IPv6 support

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> This updates xt_recent to support the IPv6 address family.
> The new /proc/net/xt_recent directory must be used for this.
> 
> Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
> ---
>  Documentation/feature-removal-schedule.txt |    3 +
>  net/netfilter/xt_recent.c                  |  271 ++++++++++++++++----
>  2 files changed, 221 insertions(+), 53 deletions(-)
> 
> diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
> index 0209a5a..9b54720 100644
> --- a/Documentation/feature-removal-schedule.txt
> +++ b/Documentation/feature-removal-schedule.txt
> @@ -249,6 +249,9 @@ What (Why):
>  	- xt_mark match revision 0
>  	  (superseded by xt_mark match revision 1)
>  
> +	- xt_recent: the old ipt_recent proc dir
> +	  (superseded by /proc/net/xt_recent)
> +

Could you introduce a new option for this please? Something
like CONFIG_NF_CONNTRACK_PROC_COMPAT.

Another thing is .. while I'm very much in favour of removing
old crap, I don't think feature-removal-schedule helps much
for informing users since basically nobody reads it (I know
I don't). So perhaps we should add a WARN_ON_ONCE or something
to interfaces scheduled for removal. Just meant for discussion,
not to be done in this patch yet.