From: Harvey Harrison <harvey.harrison-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Cc: linux-arch <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/8] kernel: move arches that use the generic_le/be helpers
Date: Thu, 10 Apr 2008 13:43:02 -0700 [thread overview]
Message-ID: <1207860182.22001.40.camel@brick> (raw)
In-Reply-To: <20080410203708.GA28014-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
On Thu, 2008-04-10 at 21:37 +0100, Ralf Baechle wrote:
> On Thu, Apr 10, 2008 at 12:44:08PM -0700, Harvey Harrison wrote:
>
> Btw, you may want to look at the current MIPS implementation of
> get_unaligned and put_unaligned. It's pure C and at least on MIPS it
> produces somewhat shorter code and the source is definately much
> shorter since it exploits the compiler's cleverness.
>
> Ralf
Yeah, the only reason I did not is that many arches intentionally bug
during the linking process when the argument size is not 1,2,4,8 whereas
some do not...it would be nice to get a decision on what is the right
answer.
Also, I saw the mips version, what would you think of moving to the
no_builtin_memcpy version from my patchset...or just look at
h3800, xtensa, or m32r arch implementations currently in tree.
Cheers,
Harvey
WARNING: multiple messages have this Message-ID (diff)
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 4/8] kernel: move arches that use the generic_le/be helpers
Date: Thu, 10 Apr 2008 13:43:02 -0700 [thread overview]
Message-ID: <1207860182.22001.40.camel@brick> (raw)
Message-ID: <20080410204302.q72lW7EVaLEuQEp08qYaNHP98Jw8TCk9mVINrriiY24@z> (raw)
In-Reply-To: <20080410203708.GA28014@linux-mips.org>
On Thu, 2008-04-10 at 21:37 +0100, Ralf Baechle wrote:
> On Thu, Apr 10, 2008 at 12:44:08PM -0700, Harvey Harrison wrote:
>
> Btw, you may want to look at the current MIPS implementation of
> get_unaligned and put_unaligned. It's pure C and at least on MIPS it
> produces somewhat shorter code and the source is definately much
> shorter since it exploits the compiler's cleverness.
>
> Ralf
Yeah, the only reason I did not is that many arches intentionally bug
during the linking process when the argument size is not 1,2,4,8 whereas
some do not...it would be nice to get a decision on what is the right
answer.
Also, I saw the mips version, what would you think of moving to the
no_builtin_memcpy version from my patchset...or just look at
h3800, xtensa, or m32r arch implementations currently in tree.
Cheers,
Harvey
next prev parent reply other threads:[~2008-04-10 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 19:44 [PATCH 4/8] kernel: move arches that use the generic_le/be helpers Harvey Harrison
2008-04-10 19:44 ` Harvey Harrison
[not found] ` <20080410203708.GA28014@linux-mips.org>
[not found] ` <20080410203708.GA28014-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
2008-04-10 20:43 ` Harvey Harrison [this message]
2008-04-10 20:43 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1207860182.22001.40.camel@brick \
--to=harvey.harrison-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.