From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [PATCH] gfs2: fix assertion in log_refund()
Date: Fri, 18 Apr 2008 17:42:05 +0100 [thread overview]
Message-ID: <1208536925.3635.412.camel@quoit> (raw)
In-Reply-To: <48076BF1.9080204@tiscali.nl>
Hi,
Now in the GFS2 -nmw git tree, which I'm just about to send a pull
request for,
Steve.
On Thu, 2008-04-17 at 17:25 +0200, Roel Kluin wrote:
> since unsigned, unused >= 0 is always true.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
> index 161ab6f..211dc2d 100644
> --- a/fs/gfs2/log.c
> +++ b/fs/gfs2/log.c
> @@ -769,8 +769,8 @@ static void log_refund(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
> sdp->sd_log_commited_revoke += tr->tr_num_revoke - tr->tr_num_revoke_rm;
> gfs2_assert_withdraw(sdp, ((int)sdp->sd_log_commited_revoke) >= 0);
> reserved = calc_reserved(sdp);
> + gfs2_assert_withdraw(sdp, sdp->sd_log_blks_reserved + tr->tr_reserved >= reserved);
> unused = sdp->sd_log_blks_reserved - reserved + tr->tr_reserved;
> - gfs2_assert_withdraw(sdp, unused >= 0);
> atomic_add(unused, &sdp->sd_log_blks_free);
> gfs2_assert_withdraw(sdp, atomic_read(&sdp->sd_log_blks_free) <=
> sdp->sd_jdesc->jd_blocks);
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: cluster-devel@redhat.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gfs2: fix assertion in log_refund()
Date: Fri, 18 Apr 2008 17:42:05 +0100 [thread overview]
Message-ID: <1208536925.3635.412.camel@quoit> (raw)
In-Reply-To: <48076BF1.9080204@tiscali.nl>
Hi,
Now in the GFS2 -nmw git tree, which I'm just about to send a pull
request for,
Steve.
On Thu, 2008-04-17 at 17:25 +0200, Roel Kluin wrote:
> since unsigned, unused >= 0 is always true.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
> index 161ab6f..211dc2d 100644
> --- a/fs/gfs2/log.c
> +++ b/fs/gfs2/log.c
> @@ -769,8 +769,8 @@ static void log_refund(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
> sdp->sd_log_commited_revoke += tr->tr_num_revoke - tr->tr_num_revoke_rm;
> gfs2_assert_withdraw(sdp, ((int)sdp->sd_log_commited_revoke) >= 0);
> reserved = calc_reserved(sdp);
> + gfs2_assert_withdraw(sdp, sdp->sd_log_blks_reserved + tr->tr_reserved >= reserved);
> unused = sdp->sd_log_blks_reserved - reserved + tr->tr_reserved;
> - gfs2_assert_withdraw(sdp, unused >= 0);
> atomic_add(unused, &sdp->sd_log_blks_free);
> gfs2_assert_withdraw(sdp, atomic_read(&sdp->sd_log_blks_free) <=
> sdp->sd_jdesc->jd_blocks);
next prev parent reply other threads:[~2008-04-18 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 15:25 [PATCH] gfs2: fix assertion in log_refund() Roel Kluin
2008-04-18 16:42 ` Steven Whitehouse [this message]
2008-04-18 16:42 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208536925.3635.412.camel@quoit \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.