All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-ppc-devel@lists.sourceforge.net, kvm-devel@lists.sourceforge.net
Subject: Re: [kvm-ppc-devel] [PATCH] Fix kvm-userspace configure script
Date: Wed, 30 Apr 2008 21:16:56 +0000	[thread overview]
Message-ID: <1209590216.25541.1.camel@thinkpadL> (raw)
In-Reply-To: <200804301614.42484.hollisb@us.ibm.com>

On Wed, 2008-04-30 at 16:14 -0500, Hollis Blanchard wrote:
> On Wednesday 30 April 2008 15:53:47 Jerone Young wrote:
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > configure |    2 +-
> > 
> > 
> > This fixes compilation for cross compilers as many do not create a 
> ${cross_prefix}cc link. But the do a ${cross_prefix}gcc. This is what the 
> kernel does so this will work for everyone. This breaks some who do not have 
> a cc link (cross tools does not create), when I put a patch to remove libkvm 
> dependence on test config.mak.

The explanation came out awful :-) .  But yes the issue is that by
default cross tools does not create a ${cross_prefix}cc symlink. So you
have to say gcc.
> > 
> > Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> > 
> > diff --git a/configure b/configure
> > --- a/configure
> > +++ b/configure
> > @@ -2,7 +2,7 @@
> > 
> >  prefix=/usr/local
> >  kerneldir=/lib/modules/$(uname -r)/build
> > -ccÌ
> > +cc=gcc
> >  ld=ld
> >  objcopy=objcopy
> >  want_module=1
> 
> To clarify: there is no such thing as "${cross_prefix}cc", so the configure 
> script is currently broken for cross-compiling.
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-ppc-devel mailing list
kvm-ppc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jerone Young <jyoung5@us.ibm.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: kvm-ppc-devel@lists.sourceforge.net, kvm-devel@lists.sourceforge.net
Subject: Re: [kvm-ppc-devel] [PATCH] Fix kvm-userspace configure script so	that cc=gcc
Date: Wed, 30 Apr 2008 16:16:56 -0500	[thread overview]
Message-ID: <1209590216.25541.1.camel@thinkpadL> (raw)
In-Reply-To: <200804301614.42484.hollisb@us.ibm.com>

On Wed, 2008-04-30 at 16:14 -0500, Hollis Blanchard wrote:
> On Wednesday 30 April 2008 15:53:47 Jerone Young wrote:
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > configure |    2 +-
> > 
> > 
> > This fixes compilation for cross compilers as many do not create a 
> ${cross_prefix}cc link. But the do a ${cross_prefix}gcc. This is what the 
> kernel does so this will work for everyone. This breaks some who do not have 
> a cc link (cross tools does not create), when I put a patch to remove libkvm 
> dependence on test config.mak.

The explanation came out awful :-) .  But yes the issue is that by
default cross tools does not create a ${cross_prefix}cc symlink. So you
have to say gcc.
> > 
> > Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> > 
> > diff --git a/configure b/configure
> > --- a/configure
> > +++ b/configure
> > @@ -2,7 +2,7 @@
> > 
> >  prefix=/usr/local
> >  kerneldir=/lib/modules/$(uname -r)/build
> > -cc=cc
> > +cc=gcc
> >  ld=ld
> >  objcopy=objcopy
> >  want_module=1
> 
> To clarify: there is no such thing as "${cross_prefix}cc", so the configure 
> script is currently broken for cross-compiling.
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

  reply	other threads:[~2008-04-30 21:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 20:53 [kvm-ppc-devel] [PATCH] Fix kvm-userspace configure script so that Jerone Young
2008-04-30 20:53 ` [PATCH] Fix kvm-userspace configure script so that cc=gcc Jerone Young
2008-04-30 21:14 ` [kvm-ppc-devel] [PATCH] Fix kvm-userspace configure script so Hollis Blanchard
2008-04-30 21:14   ` [kvm-ppc-devel] [PATCH] Fix kvm-userspace configure script so that cc=gcc Hollis Blanchard
2008-04-30 21:16   ` Jerone Young [this message]
2008-04-30 21:16     ` Jerone Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209590216.25541.1.camel@thinkpadL \
    --to=jyoung5@us.ibm.com \
    --cc=hollisb@us.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.